Skip to content

ENH: Add param to report.add_epochs to report reject/flat #12396 #13186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
34 changes: 20 additions & 14 deletions mne/report/report.py
Original file line number Diff line number Diff line change
Expand Up @@ -1249,19 +1249,26 @@ def add_epochs(
.. versionadded:: 0.24
"""
tags = _check_tags(tags)
add_projs = self.projs if projs is None else projs
self._add_epochs(
epochs=epochs,
psd=psd,
add_projs=add_projs,
image_kwargs=image_kwargs,
topomap_kwargs=topomap_kwargs,
drop_log_ignore=drop_log_ignore,
section=title,
tags=tags,
image_format=self.image_format,
replace=replace,
)

add_projs = self.projs if projs is None else projs

if epochs._bad_dropped:
reject_info = f"<p><strong>Rejection Thresholds:</strong> {epochs.reject}</p>"
flat_info = f"<p><strong>Flat Thresholds:</strong> {epochs.flat}</p>"
self.add_html(reject_info + flat_info)

self._add_epochs(
epochs=epochs,
psd=psd,
add_projs=add_projs,
image_kwargs=image_kwargs,
topomap_kwargs=topomap_kwargs,
drop_log_ignore=drop_log_ignore,
section=title,
tags=tags,
image_format=self.image_format,
replace=replace,
)
Comment on lines +1253 to +1271
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks wrong, why is it unindented to be outside the method?


@fill_doc
def add_evokeds(
Expand Down Expand Up @@ -2225,7 +2232,6 @@ def _add_or_replace(self, *, title, section, tags, html_partial, replace=False):
The tags associated with the added element.
html_partial : callable
Callable that renders a HTML string, called as::

html_partial(id_=...)
replace : bool
Whether to replace existing content if the title and section match.
Expand Down
Loading
Loading