Skip to content

Fix an off by one issue affecting number of iterations in multiple optimizers. #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+64 −22
Open

Fix an off by one issue affecting number of iterations in multiple optimizers. #443

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f25f53c
Fix GradientDescent iterations off by one issue
ranjodhsingh1729 Oct 19, 2025
70e5e0e
Address review suggestions
ranjodhsingh1729 Oct 20, 2025
0cac8ca
Apply fix for other optimizers
ranjodhsingh1729 Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions include/ensmallen_bits/gradient_descent/gradient_descent_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,13 @@ GradientDescent::Optimize(FunctionType& function,
// Controls early termination of the optimization process.
bool terminate = false;

// actualMaxIterations (0 means no limit)
const size_t actualMaxIterations = (maxIterations == 0) ?
std::numeric_limits<size_t>::max() : maxIterations;

// Now iterate!
Callback::BeginOptimization(*this, f, iterate, callbacks...);
for (size_t i = 1; i != maxIterations && !terminate; ++i)
for (size_t i = 1; i <= actualMaxIterations && !terminate; ++i)
{
overallObjective = f.EvaluateWithGradient(iterate, gradient);

Expand Down Expand Up @@ -159,4 +163,4 @@ GradientDescent::Optimize(

} // namespace ens

#endif
#endif