Update build.rs #26
Open
Update build.rs #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure but msvc doen't have -Werror flag
Anyway, I have some bug with compiling on Windows:
error: failed to run custom build command for
tblgen v0.6.0Caused by:
process didn't exit successfully:
D:\spaceless\projs\rolang\target\debug\build\tblgen-a0e5f371761e9f4a\build-script-build(exit code: 1)--- stderr
error occurred in cc-rs: command did not execute successfully (status code exit code: 2): "D:\_programs\VS\2022\VC\Tools\MSVC\14.44.35207\bin\HostX64\x64\cl.exe" "-nologo" "-MD" "-Z7" "-Brepro" "-std:c++17" "-I" "cc/include" "-I" "D:/_programs/msys64/clang64/include" "-Werror" "-ID:/_programs/msys64/clang64/include" "-std=c++17" "-stdlib=libc++" "-fno-exceptions" "-funwind-tables" "-D_FILE_OFFSET_BITS=64" "-D__STDC_CONSTANT_MACROS" "-D__STDC_FORMAT_MACROS" "-D__STDC_LIMIT_MACROS" "-FoD:\spaceless\projs\rolang\target\debug\build\tblgen-c2973b152bb99b4a\out\eaa0b8528c4d35fb-Record.o" "-c" "cc/lib\Record.cpp"
warning: tblgen@0.6.0: cl: ��������� ��ப� error D8021: �������⨬� ���� ��㬥�� "/Werror"
#edit:
even with this fix it for some reason gives more warnings:
warning: tblgen@0.6.0: cl: ��������� ��ப� warning D9002: �ய�� �������⭮�� ��ࠬ��� "-std=c++17"
warning: tblgen@0.6.0: cl: ��������� ��ப� warning D9002: �ய�� �������⭮�� ��ࠬ��� "-stdlib=libc++"
warning: tblgen@0.6.0: cl: ��������� ��ப� warning D9002: �ய�� �������⭮�� ��ࠬ��� "-fno-exceptions"
warning: tblgen@0.6.0: cl: ��������� ��ப� warning D9002: �ய�� �������⭮�� ��ࠬ��� "-funwind-tables"
Maybe, think about this pull request not about as pull request but as a bug representation (cl takes unknown for it flags on Windows). I'm just new to github and not sure how to do it normally and also do not undarstand how
ccworks.