Add a bundled mode to download LLVM automatically in the build.rs #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm writing a CPU backend in https://github.com/tracel-ai/cubecl and I needed to make mlir-sys a bit more portable and add a way to not depend on the system installation of llvm which could not be the good version. I wrote a crate to add this capability to tblgen-rs also. https://github.com/marcantoinem/llvm-bundler-rs The crates use a github action to get a specific version llvm compile it and compress it into a Github release that is then downloaded during compilation. I would love to merge it upstream. It also contains fixes to allow static linking for MLIR by reading the mlir dependency cmake and doing a topological sort. I would like to move this crate in the mlir-rs organisation to make it more trustworthy.
It also support only linux for the moment, but I will add MacOs and Windows support soon.