Path string fix #376
Merged
Path string fix #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
arjunsuresh
reviewed
Apr 22, 2025
| @@ -119,14 +119,14 @@ def postprocess(i): | |||
|
|
|||
| if mode == "accuracy" or mode == "compliance" and env[ | |||
| 'MLC_MLPERF_LOADGEN_COMPLIANCE_TEST'] == "TEST01": | |||
| out_baseline_accuracy_string = f"""> {os.path.join(output_dir, "accuracy", "baseline_accuracy.txt")} """ | |||
| out_compliance_accuracy_string = f"""> {os.path.join(output_dir, "accuracy", "compliance_accuracy.txt")} """ | |||
| out_baseline_accuracy_string = f"""> '{os.path.join(output_dir, "accuracy", "baseline_accuracy.txt")}' """ | |||
There was a problem hiding this comment.
Hi @anandhu-eng we need to use a variable for adding quote as we should use ' for Unix shell and " for Windows.
There was a problem hiding this comment.
@arjunsuresh , yes that's correct. Also are you aware whether the following works in windows:
python3 "/some/path/try.py"
There was a problem hiding this comment.
I think in one of our GH actions we can export MLC_REPOS to a path containing space and test it.
There was a problem hiding this comment.
I have made the changes in resnet50 closed division itself so that we could test even the compliance also. But for that, this PR needs to be merged to trigger the workflow.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to issue: #247
Failing GitHub actions: https://github.com/mlcommons/mlperf-automations/actions/runs/14150821438/job/39643726179