Replace KSM with 1Password in test-mlperf-inference-tvm-resnet50.yml #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
…mmons-cpp-resnet50.yml
…f-onnxruntime-pytorch.yml
arjunsuresh
approved these changes
Apr 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're transitioning from Keeper to 1Password as our password and secrets manager. This PR accordingly updates various GitHub Actions workflows to use the 1Password secret loader action instead of KSM in order to pull the GitHub PAT. This PR should be merged before our Keeper subscription expires on Apr 15.
I'll note that the op-load-secret action currently does not support Windows runners. As a result, I had to develop a workflow template that pulls the secret in an Ubuntu runner, encrypts it, then outputs it for it to be pulled in by other jobs, including ones using Windows runners, decrypted, then used. Hopefully 1Password will update its Action soon so we can simplify this process by directly using the op-load-secret action in Windows runners.