Skip to content

Fix for dmidecode + support mounting filepaths in docker #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 15, 2025
Merged

Fix for dmidecode + support mounting filepaths in docker #344

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
48f74d5
fix for dmidecode
anandhu-eng Apr 1, 2025
9af8083
support mounting file paths in docker
anandhu-eng Apr 2, 2025
6b73726
[Automated Commit] Format Codebase [skip ci]
github-actions[bot] Apr 2, 2025
abf53b6
Merge branch 'dev' into sub-gen-patch
anandhu-eng Apr 2, 2025
845b141
update logic flow
anandhu-eng Apr 8, 2025
5e9f7e4
handle relative path in get_container_value
anandhu-eng Apr 9, 2025
5fb35f3
handle extraction of parent directory properly
anandhu-eng Apr 10, 2025
8a5111f
[Automated Commit] Format Codebase [skip ci]
github-actions[bot] Apr 10, 2025
3b730f8
file updated
anandhu-eng Apr 10, 2025
76c3353
Merge branch 'sub-gen-patch' of https://github.com/anandhu-eng/mlperf…
anandhu-eng Apr 10, 2025
2595369
handle directory extraction using file and folder path env keys
anandhu-eng Apr 14, 2025
799500e
[Automated Commit] Format Codebase [skip ci]
github-actions[bot] Apr 14, 2025
6b7c7e1
Merge branch 'dev' into sub-gen-patch
anandhu-eng Apr 14, 2025
0e83b5c
clean code
anandhu-eng Apr 15, 2025
7e127ac
file_path_env_keys made part of general meta
anandhu-eng Apr 15, 2025
094657f
[Automated Commit] Format Codebase [skip ci]
github-actions[bot] Apr 15, 2025
a288fe7
run gh action
anandhu-eng Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script/get-mlperf-inference-sut-description/detect_memory.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
if [[ ${MLC_SUDO_USER} == "yes" ]]; then
${MLC_SUDO} dmidecode -t memory > ${MLC_MEMINFO_FILE}
fi
test $? -eq 0 || return $?
test $? -eq 0 || echo "Warning: Memory info is not recorded"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dmidecode exits with error no device error. Maybe due to permission error with dmidecode inside docker containers. Would it be okay if we just print warnings instead of exiting.

4 changes: 4 additions & 0 deletions script/get-mlperf-inference-sut-description/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ deps:
MLC_HOST_OS_TYPE:
- linux
tags: detect,sudo
- skip_if_env:
MLC_SUDO_USER:
- 'no'
tags: get,sys-util,generic,_dmidecode
- env:
MLC_CACHE_DIR_ENV_NAME: MLC_MLPERF_INFERENCE_SUT_DESC_PATH
extra_cache_tags: mlperf,inference,sut,descriptions
Expand Down
Loading