Skip to content

Fix mlperf inference docker run on Windows #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Fix mlperf inference docker run on Windows #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f66a32
Fix docker run on windows, install-pip-package-for-mlc
arjunsuresh Feb 5, 2025
0165cbc
[Automated Commit] Format Codebase
github-actions[bot] Feb 5, 2025
d5b6e87
Merge branch 'dev' into dev
arjunsuresh Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script/app-mlperf-inference/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ deps:
- 'yes'
- tags: get,mlperf,inference,utils

- tags: install,pip-package,for-cmind-python,_package.pandas
- tags: install,pip-package,for-mlc-python,_package.pandas
enable_if_env:
MLC_PROFILE_NVIDIA_POWER:
- on
Expand Down
2 changes: 1 addition & 1 deletion script/generate-mlperf-inference-submission/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ deps:
- inference-src
tags: mlcommons,inference,src
- tags: get,sut,system-description
- tags: install,pip-package,for-cmind-python,_package.tabulate
- tags: install,pip-package,for-mlc-python,_package.tabulate
- tags: get,mlperf,inference,utils
- names:
- get-mlperf-results-dir
Expand Down
1 change: 0 additions & 1 deletion script/install-pip-package-for-cmind-python/README.md
View file
Open in desktop

This file was deleted.

0 ...pip-package-for-cmind-python/COPYRIGHT.md → ...l-pip-package-for-mlc-python/COPYRIGHT.md
View file
Open in desktop
File renamed without changes.
0 ...pip-package-for-cmind-python/customize.py → ...l-pip-package-for-mlc-python/customize.py
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions ...ll-pip-package-for-cmind-python/meta.yaml → ...tall-pip-package-for-mlc-python/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
alias: install-pip-package-for-cmind-python
alias: install-pip-package-for-mlc-python
automation_alias: script
automation_uid: 5b4e0237da074764
cache: true
Expand All @@ -7,8 +7,8 @@ tags:
- pip
- package
- pip-package
- for-cmind-python
- for.cmind-python
- for-mlc-python
- for.mlc-python
uid: b16ed087abab459c

variations:
Expand Down
3 changes: 2 additions & 1 deletion script/run-docker-container/customize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,8 @@ def postprocess(i):
for mounts in env['MLC_DOCKER_VOLUME_MOUNTS']:
mount_cmds.append(mounts)

if env.get('MLC_DOCKER_PASS_USER_GROUP', '') != '':
if env.get('MLC_DOCKER_PASS_USER_GROUP',
'') != '' and os_info['platform'] != 'windows':
run_opts += " --group-add $(id -g $USER) "

if env.get('MLC_DOCKER_ADD_DEVICE', '') != '':
Expand Down
2 changes: 1 addition & 1 deletion script/run-mlperf-automotive-app/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ deps:
MLC_MLPERF_USE_DOCKER: [ off ]
skip_if_env:
OUTPUT_BASE_DIR: [ on ]
- tags: install,pip-package,for-cmind-python,_package.tabulate
- tags: install,pip-package,for-mlc-python,_package.tabulate
- tags: get,mlperf,inference,utils
skip_if_env:
MLC_MLPERF_USE_DOCKER: [ on ]
Expand Down
4 changes: 1 addition & 3 deletions script/run-mlperf-inference-app/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,9 @@ deps:
- tags: get,mlperf,inference,results,dir
names:
- get-mlperf-inference-results-dir
enable_if_env:
MLC_MLPERF_USE_DOCKER: [ off ]
skip_if_env:
OUTPUT_BASE_DIR: [ on ]
- tags: install,pip-package,for-cmind-python,_package.tabulate
- tags: install,pip-package,for-mlc-python,_package.tabulate
- tags: get,mlperf,inference,utils

#We use this script as a command generator to run docker via app-mlperf-inference script
Expand Down
Loading