Skip to content

Code changes for supporting llama3_1-405b reference implementation #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 5, 2025

Conversation

anandhu-eng
Copy link
Contributor

@anandhu-eng anandhu-eng commented Jan 4, 2025

TODO:

  1. Add the correct rclone directory path to get-dataset-mlperf-inference-llama3.
  2. Accuracy script has been tested separately, a complete test run needs to be conducted.

@anandhu-eng anandhu-eng requested a review from a team as a code owner January 4, 2025 06:01
Copy link
Contributor

github-actions bot commented Jan 4, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

- llama3-402b
skip_if_env:
CM_ML_MODEL_LLAMA3_CHECKPOINT_PATH:
- 'on'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also only if we are in the docker build stage. Otherwise when the path is given we should register it in CM cache

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in commit bfb7cb6

- llama3-402b
skip_if_env:
CM_DATASET_LLAMA3_PATH:
- "on"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as for the model.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in commit bfb7cb6

env:
CM_MODEL_ZOO_ENV_KEY: LLAMA3
group: huggingface-stub
docker:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this docker section needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in commit a21f2b0

skip_if_env:
CM_DATASET_LLAMA3_PATH:
- "on"
CM_USE_DATASET_FROM_HOST:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable is not needed right? Because if the path is directly passed from the host to a container then, this won't work. Same for model.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, thanks. Also I formatted the app-mlperf-inference-mlcommons-python _cm.yaml file with the help of prettier extension in VS Code.

@arjunsuresh arjunsuresh merged commit c32d3a5 into mlcommons:dev Jan 5, 2025
63 of 70 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants