Fix type error #830 #831
Merged
Fix type error #830 #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a type error by adding explicit type conversion and error handling for new configuration parameters.
- Updated type conversion logic in _set_from_conf to catch conversion errors and set invalid values to None.
- Updated constructor calls for force_cpu_power, force_ram_power, and force_mode_cpu_load with explicit type conversions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_config.py | Added tests for new force_cpu_power and force_ram_power parameters to check type conversion outcomes. |
| codecarbon/emissions_tracker.py | Modified configuration parsing to include explicit type conversion and error handling for new parameters. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
inimaz
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an error of type for new parameters.
Will close #830