-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Serving] Support tool function calls under strict format constraints #3190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Irfnfnkemed
wants to merge
22
commits into
mlc-ai:main
Choose a base branch
from
Irfnfnkemed:tool_call
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+809
−52
Open
Changes from 15 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
712f1d5
[Grammar] Upgrade xgrammar to latest version
Irfnfnkemed 8a84e59
Merge branch 'mlc-ai:main' into main
Irfnfnkemed 6e37a0b
Updated submodule-xgrammar references
Irfnfnkemed f70a37a
[fix] modify cmake since xgrammar use nanobind to replace pybind
Irfnfnkemed 6e7426e
[feature] Support tool function calling with Structural Tag with xgra…
Irfnfnkemed 4f980f3
[feat] Add Structural-Tag api to RequestResponseFormat
Irfnfnkemed 8b70dd7
[fix] type annotation in test scripts
Irfnfnkemed 7df3f34
[feat] Support tool function calls under strict format constraints
Irfnfnkemed 6a97012
Merge branch 'mlc-ai:main' into tool_call
Irfnfnkemed 379ce42
[fix] Trigger CI on branch
Irfnfnkemed a5143a2
[format] adjust the format
Irfnfnkemed 5605045
[fix] fix some typos
Irfnfnkemed 3f277e6
[feat] Add 'json' format mode for tool calls
Irfnfnkemed 6119904
Merge branch 'mlc-ai:main' into tool_call
Irfnfnkemed 98d9671
Merge branch 'mlc-ai:main' into tool_call
Irfnfnkemed 5c99831
[feat] initial version of the stag-eval script
Irfnfnkemed b8c331a
[feat] using structural tag to support func-call with the latest version
Irfnfnkemed c0f235f
[fix] remove CI check for other branch
Irfnfnkemed 7e4da8f
[fix] missing type check for RequestFormat type
Irfnfnkemed 3ddacf0
Update config.h
Irfnfnkemed 9dace3a
[fix] remove unexpected prompt when don't use func-call
Irfnfnkemed 2fba444
Merge branch 'tool_call' of github.com:Irfnfnkemed/mlc-llm into tool_…
Irfnfnkemed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ on: | |
push: | ||
branches: | ||
- main | ||
- tool_call | ||
|
||
jobs: | ||
test_linux: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ on: | |
push: | ||
branches: | ||
- main | ||
- tool_call | ||
pull_request: | ||
branches: | ||
- main | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -81,6 +81,8 @@ class Conversation(BaseModel): | |||||
function_string: str = "" | ||||||
# whether using function calling or not, helps check for output message format in API call | ||||||
use_function_calling: bool = False | ||||||
# Tool function call format mode | ||||||
tool_call_format: str = "default" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
def __init__(self, role_templates: Optional[Dict[str, str]] = None, **kwargs): | ||||||
# Defaults templates which would be overridden by model specific templates | ||||||
|
@@ -124,6 +126,7 @@ def as_prompt(self, config=None) -> List[Any]: | |||||
from ..serve import data # pylint: disable=import-outside-toplevel | ||||||
|
||||||
# - Get the system message. | ||||||
self.set_tool_call_format_in_system_message() | ||||||
system_msg = self.system_template.replace( | ||||||
MessagePlaceholders.SYSTEM.value, self.system_message | ||||||
) | ||||||
|
@@ -192,9 +195,46 @@ def as_prompt(self, config=None) -> List[Any]: | |||||
) | ||||||
# Replace with remaining function string placeholders with empty string | ||||||
prompt[0] = prompt[0].replace(MessagePlaceholders.FUNCTION.value, "") | ||||||
|
||||||
return prompt | ||||||
|
||||||
def set_tool_call_format_in_system_message(self): | ||||||
"""Add tool function information and call format to the system message.""" | ||||||
if self.tool_call_format == "xml": | ||||||
tool_call_instruct = ( | ||||||
"Tool Instructions:" | ||||||
f"You have access to the following tool functions: {MessagePlaceholders.FUNCTION.value}" | ||||||
"If a you choose to call a function, you should ONLY reply in the following format:" | ||||||
"`<function={func name}>\n{parameters(JSON dict)}\n</function>`" | ||||||
"Here is an example," | ||||||
'`<function=get_time>\n{"location": "Pittsburgh"}\n</function>`' | ||||||
"Reminder:" | ||||||
"- Function calls MUST follow the specified format" | ||||||
"- Required parameters MUST be specified" | ||||||
) | ||||||
self.system_message += tool_call_instruct | ||||||
elif self.tool_call_format == "json": | ||||||
tool_call_instruct = ( | ||||||
"Tool Instructions:" | ||||||
f"You have access to the following tool functions: {MessagePlaceholders.FUNCTION.value}" | ||||||
"If a you choose to call a function, you should ONLY reply in the following format:" | ||||||
'`{"name": func_name, "parameters": parameters(JSON dict)}`' | ||||||
"Here is an example," | ||||||
'`{"name": "get_time", "parameters": {"location": "Pittsburgh"} }`' | ||||||
"Reminder:" | ||||||
"- Function calls MUST follow the specified format" | ||||||
"- Required parameters MUST be specified" | ||||||
) | ||||||
self.system_message += tool_call_instruct | ||||||
elif self.tool_call_format == "python": | ||||||
tool_call_instruct = ( | ||||||
"Tool Instructions:" | ||||||
f"- You have access to the following tool functions: {MessagePlaceholders.FUNCTION.value}" | ||||||
"- Required parameters MUST be specified" | ||||||
) | ||||||
self.system_message += tool_call_instruct | ||||||
else: | ||||||
raise ValueError("Unknown tool calling format.") | ||||||
|
||||||
|
||||||
def _get_url_from_item(item: Dict) -> str: | ||||||
image_url: str | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -86,12 +86,34 @@ class ModelResponse(BaseModel): | |
|
||
|
||
class RequestResponseFormat(BaseModel): | ||
type: Literal["text", "json_object"] = "text" | ||
json_schema: Optional[str] = Field(default=None, alias="schema") | ||
type: Literal["text", "json_object", "structural_tag"] = "text" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
"""This field is named json_schema instead of schema because BaseModel defines a method called | ||
schema. During construction of RequestResponseFormat, key "schema" still should be used: | ||
`RequestResponseFormat(type="json_object", schema="{}")` | ||
""" | ||
json_schema: Optional[str] = Field(default=None, alias="schema") | ||
|
||
"""These field are only used for type="structural_tag".""" | ||
tags: Optional[List[Dict[str, str]]] = Field(default=None, alias="tags") | ||
triggers: Optional[List[str]] = Field(default=None, alias="triggers") | ||
|
||
@model_validator(mode="after") | ||
def check_request_response_format(self) -> "RequestResponseFormat": | ||
"""Check if the RequestResponseFormat is valid.""" | ||
if self.type == "structural_tag": | ||
if self.tags is None or self.triggers is None: | ||
raise ValueError("structural_tag type must contain keys 'tags' and 'triggers'.") | ||
for tag in self.tags: | ||
if set(tag.keys()) != {"begin", "schema", "end"}: | ||
raise ValueError( | ||
f"Each tag must contain exactly 'begin', 'schema' and 'end' keys. Got keys: {list(tag.keys())}." | ||
) | ||
elif self.tags is not None or self.triggers is not None: | ||
raise Warning( | ||
"'tags' and 'triggers' attributes should be used when type='structural_tag'" | ||
) | ||
|
||
return self | ||
|
||
|
||
class CompletionRequest(BaseModel): | ||
|
@@ -181,6 +203,7 @@ class ChatFunction(BaseModel): | |
description: Optional[str] = None | ||
name: str | ||
parameters: Dict | ||
strict: bool = True | ||
|
||
|
||
class ChatTool(BaseModel): | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
align with openai api