Remove transformOutput combinator
#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fact that `transformOutput` required an `InvalidInputError` to be explicitly created in order to model failure made this function difficult to use (you had to keep track of your own `input`, etc). I considered changing the signature to instead only require an error message, but ultimately decided to ditch it entirely for now. Either change is semver-major and I don't currently use `transformOutput` at all (and I believe I'm still the sole consumer of this package).
mkantor
force-pushed
the
nuke-transform-output-combinator
branch
from
422557e to
7efa7c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that
transformOutputrequired anInvalidInputErrorto be explicitly created in order to model failure made this function difficult to use (you had to keep track of your owninput, etc). I considered changing the signature to instead only require an error message, but ultimately decided to ditch it entirely for now. Either change is semver-major and I don't currently usetransformOutputat all (and I believe I'm still the sole consumer of this package).