Charles geom weighted dots #254
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katossky
reviewed
Apr 13, 2025
| @@ -1,4 +1,5 @@ | |||
| Version: 1.0 | |||
| ProjectId: 6d5d45db-7d92-4c58-a207-fc4818e89984 | |||
There was a problem hiding this comment.
This should not be in the merge request ; please update :)
katossky
reviewed
Apr 13, 2025
| @@ -713,3 +713,191 @@ GeomDots$default_key_aes$slab_size = NULL | |||
| #' @eval rd_dotsinterval_shortcut_geom("dots", "dot") | |||
| #' @export | |||
| geom_dots = make_geom(GeomDots) | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
This is probably left over from a merge. Please remove ! (You only have to make new commits to your own branch and it should (?) update the pull request CharlesSnt:Charles_Geom_Weighted_Dots.
|
Could you provide a toy example of a graph using your new method ? You can post both the code and the result in the original issue #218 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @nowibct in our work with @katossky. We tried to implement the geom_weighted_dots function that you mentionned on your issue #218. The test function that we inputed in the ?help part works just fine for us, but I think you shall do some more testing on your side in order to perfect it. We hope that our help was useful for you.