Latest opentelemetry #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Niroshan2001 wants to merge 48 commits into miyurud:master from Niroshan2001:latest-opentelemetry

Contributor

Niroshan2001 commented Oct 10, 2025

No description provided.

Niroshan2001 and others added 20 commits

August 25, 2025 11:51


          initaial setup for telemtry

123fd14


          automate link between parent and child

e1008ad


          Merge remote-tracking branch 'origin/master' into opentelemetry

c939607


          fix segmentation issue

052062f


          open telemetry integrated successfully

2a50b41


          some overhead reduced

3cfcf16


          initially worked for workers

0cb9f7b


          refactor the codebase

3e597f0


          Merge branch 'master' of https://github.com/Niroshan2001/jasminegraph …

ad76f71

…into opentelemtry_cleanup


          refactor codebase

178358c


          remove some files

0bb58dc


          minor changes

92b1bbe


          fix style issue

a3d2806


          add jasminegraph-prerequisites:20250930T172442

001c32b


          update dockerfile

b40cf82


          fix syle issue

b785906


          comment initialization

6e08022


          add isTelemetrEnabled

5dcfec9


          initiallized

c66af38


          fix tests

66ab684

Niroshan2001 force-pushed the latest-opentelemetry branch from 0a31b41 to 66ab684 Compare

October 14, 2025 01:54

Niroshan2001 added 9 commits

October 18, 2025 17:08


          fix style issue

f514393


          fixing segmentation fault

2465fd2


          fix style issue

a4ed227


          fix style

a3d9c50


          disable telemetry for unit test


          fix style

d4e7419


          minor changes

c20af39


          fix style issue

028c492


          add global exit handler

6d3d56b

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/OpenTelemetryUtil.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/TelemetryInitializer.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/TelemetryInitializer.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/TelemetryInitializer.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/TelemetryInitializer.cpp Outdated

    
                      } else {

                          std::cout << "Initializing OpenTelemetry for worker..." << std::endl;

                          serviceName = "jasminegraph-worker";

                          otlpEndpoint = "http://172.28.5.1:4318/v1/traces";  // Host IP for worker containers

Owner

miyurud Oct 26, 2025

Why this IP address and port hardcoded here?

Contributor Author

Niroshan2001 Oct 27, 2025

modify to http://tempo:4318/v1/traces

miyurud reviewed

View reviewed changes

src/util/telemetry/TelemetryInitializer.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/TelemetryInitializer.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/TelemetryInitializer.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/util/telemetry/TelemetryInitializer.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

tests/unit/CMakeLists.txt Show resolved Hide resolved

miyurud requested changes

View reviewed changes

Owner

miyurud left a comment

I have put comments. Please address each one of those and reply explaining how you addressed those.

Niroshan2001 added 2 commits

October 27, 2025 12:21


          replace cout, cerr with loggers

2940e18


          address other comments

sonarqubecloud bot commented Oct 27, 2025

Quality Gate failed

Failed conditions
3 Security Hotspots

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet