Skip to content

Fix/miduweb 1962 tabindex of all components toolbox plus miduca #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix/miduweb 1962 tabindex of all components toolbox plus miduca #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d7a07c0
expl
Oct 16, 2025
f6ea2ea
just work...
edmgb Oct 17, 2025
0966d45
changes
edmgb Oct 21, 2025
ecb92f2
changes
edmgb Oct 21, 2025
0721f2a
Merge remote-tracking branch 'origin/fix/MIDUWEB-1962_tabindex-of-all…
edmgb Oct 21, 2025
225473e
changes
edmgb Oct 21, 2025
7fd1e9a
changes
edmgb Oct 21, 2025
04f4d36
Merge branch 'master' into fix/MIDUWEB-1962_tabindex-of-all-component…
edmgb Oct 22, 2025
919b7e6
Merge branch 'master' into fix/MIDUWEB-1962_tabindex-of-all-component…
edmgb Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/es/components/atoms/breadcrumb/Breadcrumb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { Shadow } from '../../prototypes/Shadow.js'
*/
export default class Breadcrumb extends Shadow() {
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, ...options }, ...args)
super({ importMetaUrl: import.meta.url, tabindex: 'no-tabindex', ...options }, ...args)
}

connectedCallback () {
Expand Down
1 change: 1 addition & 0 deletions src/es/components/atoms/emotionPictures/EmotionPictures.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export default class EmotionPictures extends Intersection() {
super({
importMetaUrl: import.meta.url,
intersectionObserverInit: { rootMargin: '0px', threshold: 0.75 },
tabindex: 'no-tabindex',
...options
}, ...args)

Expand Down
2 changes: 1 addition & 1 deletion src/es/components/atoms/logo/Logo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ import { Shadow } from '../../prototypes/Shadow.js'
*/
export default class Logo extends Shadow() {
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, ...options }, ...args)
super({ importMetaUrl: import.meta.url, tabindex: 'no-tabindex', ...options }, ...args)

this.textSelector = ':not(img):not(a):not(style):not(script)'
this.setAttribute('lang', document.documentElement.getAttribute('lang') || 'de')
Expand Down
2 changes: 1 addition & 1 deletion src/es/components/atoms/oneTrust/OneTrust.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default class OneTrust extends Shadow() {
* @param {any} args
*/
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, mode: 'false', ...options }, ...args)
super({ importMetaUrl: import.meta.url, mode: 'false', tabindex: 'no-tabindex', ...options }, ...args)
}

connectedCallback () {
Expand Down
3 changes: 3 additions & 0 deletions src/es/components/atoms/translation/Translation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ import { Shadow } from '../../prototypes/Shadow.js'
* @type {CustomElementConstructor}
*/
export default class Translation extends Shadow() {
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, tabindex: 'no-tabindex-style', ...options }, ...args)
}
static get observedAttributes () {
return ['data-trans-key', 'key']
}
Expand Down
2 changes: 1 addition & 1 deletion src/es/components/atoms/video/Video.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ import { Shadow } from '../../prototypes/Shadow.js'
*/
export default class Video extends Shadow() {
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, ...options }, ...args)
super({ importMetaUrl: import.meta.url, tabindex: 'no-tabindex', ...options }, ...args)
this.sources = (this.getAttribute('sources') && Video.parseAttribute(this.getAttribute('sources'))) || null
}

Expand Down
2 changes: 1 addition & 1 deletion src/es/components/molecules/bentoGridTeaser/BentoGridTeaser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Shadow } from '../../prototypes/Shadow.js'
export default class BentoGridTeaser extends Shadow() {
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, ...options }, ...args)
super({ importMetaUrl: import.meta.url, tabindex: 'no-tabindex', ...options }, ...args)
}

connectedCallback () {
Expand Down
2 changes: 1 addition & 1 deletion src/es/components/molecules/carousel/Carousel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ import { Shadow } from '../../prototypes/Shadow.js'
*/
export default class MacroCarousel extends Shadow() {
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, ...options }, ...args)
super({ importMetaUrl: import.meta.url, tabindex: 'no-tabindex', ...options }, ...args)

this.macroCarousel = document.createElement('macro-carousel')
// copy all kids into the macro-carousel
Expand Down
1 change: 1 addition & 0 deletions src/es/components/molecules/carouselTwo/CarouselTwo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export default class CarouselTwo extends Mutation() {
super({
importMetaUrl: import.meta.url,
mutationObserverInit: { subtree: true, childList: true },
tabindex: 'no-tabindex',
...options
}, ...args)

Expand Down
1 change: 1 addition & 0 deletions src/es/components/molecules/details/Details.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export const Details = (ChosenHTMLElement = Mutation(Anchor())) => class Details
super({
importMetaUrl: import.meta.url,
mutationObserverInit: { attributes: true, attributeFilter: ['open'] },
tabindex: 'no-tabindex',
...options
}, ...args)

Expand Down
4 changes: 1 addition & 3 deletions src/es/components/molecules/dialog/Dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { Shadow } from '../../prototypes/Shadow.js'
*/
export default class Dialog extends Shadow() {
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, ...options }, ...args)
super({ importMetaUrl: import.meta.url, tabindex: 'no-tabindex', ...options }, ...args)

/**
* @param {'show'|'showModal'} [command='show']
Expand Down Expand Up @@ -152,8 +152,6 @@ export default class Dialog extends Shadow() {
renderCSS () {
this.css = /* css */`
:host {
--outline-style: none;
outline: none !important;
position: relative;
${this.hasAttribute('dialog-desktop-height')
? `
Expand Down
2 changes: 1 addition & 1 deletion src/es/components/molecules/emotionCarousel/EmotionCarousel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Shadow } from '../../prototypes/Shadow.js'

export default class EmotionCarousel extends Shadow() {
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, ...options }, ...args)
super({ importMetaUrl: import.meta.url, tabindex: 'no-tabindex', ...options }, ...args)
this.emotionPictures
this.timer
this.breakPoint = parseInt(self.Environment.mobileBreakpoint().replace('px', ''), 10)
Expand Down
2 changes: 1 addition & 1 deletion src/es/components/molecules/factsAndFigures/factsAndFigures.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Shadow } from '../../prototypes/Shadow.js'

export default class SustainabilityMetrics extends Shadow() {
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, ...options }, ...args)
super({ importMetaUrl: import.meta.url, tabindex: 'no-tabindex', ...options }, ...args)
}

connectedCallback () {
Expand Down
2 changes: 1 addition & 1 deletion src/es/components/molecules/historyGallery/HistoryGallery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Shadow } from '../../prototypes/Shadow.js'
export default class HistoryGallery extends Shadow() {
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, ...options }, ...args)
super({ importMetaUrl: import.meta.url, tabindex: 'no-tabindex', ...options }, ...args)
}

connectedCallback () {
Expand Down
2 changes: 1 addition & 1 deletion src/es/components/molecules/metaHeader/MetaHeader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Shadow } from '../../prototypes/Shadow.js'

export default class MetaHeader extends Shadow() {
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, ...options }, ...args)
super({ importMetaUrl: import.meta.url, tabindex: 'no-tabindex', ...options }, ...args)
}

connectedCallback () {
Expand Down
2 changes: 1 addition & 1 deletion src/es/components/organisms/body/Body.js
View file
Open in desktop
Copy link
Member

@Weedshaker Weedshaker Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"no-tabindex"

Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { Anchor } from '../../prototypes/Anchor.js'
*/
export default class Body extends Anchor() {
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, ...options }, ...args)
super({ importMetaUrl: import.meta.url, tabindex: 'no-tabindex-style', ...options }, ...args)
}

connectedCallback () {
Expand Down
2 changes: 1 addition & 1 deletion src/es/components/organisms/footer/Footer.js
View file
Open in desktop
Copy link
Member

@Weedshaker Weedshaker Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"no-tabindex"

Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import { Shadow } from '../../prototypes/Shadow.js'
*/
export default class Footer extends Shadow() {
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, ...options }, ...args)
super({ importMetaUrl: import.meta.url, tabindex: 'no-tabindex-style', ...options }, ...args)

this.setAttribute('role', 'navigation')
this.setAttribute('aria-label', 'Footer')
Expand Down
2 changes: 1 addition & 1 deletion src/es/components/organisms/grid/Grid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { Shadow } from '../../prototypes/Shadow.js'
*/
export default class Grid extends Shadow() {
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, ...options }, ...args)
super({ importMetaUrl: import.meta.url, tabindex: 'no-tabindex', ...options }, ...args)
}

connectedCallback () {
Expand Down
2 changes: 1 addition & 1 deletion src/es/components/organisms/header/Header.js
View file
Open in desktop
Copy link
Member

@Weedshaker Weedshaker Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"no-tabindex"

Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ import { Shadow } from '../../prototypes/Shadow.js'
*/
export default class Header extends Shadow() {
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, ...options }, ...args)
super({ importMetaUrl: import.meta.url, tabindex: 'no-tabindex-style', ...options }, ...args)

this.noScroll = () => { window.scroll(0, 0) }
this.setAttribute('role', 'banner')
Expand Down
2 changes: 1 addition & 1 deletion src/es/components/organisms/wrapper/Wrapper.js
View file
Open in desktop
Copy link
Member

@Weedshaker Weedshaker Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"no-tabindex"

Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import Body from '../body/Body.js'
// extend body for scroll to anchor behavior
export const Wrapper = (ChosenHTMLElement = Body) => class Wrapper extends ChosenHTMLElement {
constructor (options = {}, ...args) {
super({ importMetaUrl: import.meta.url, ...options }, ...args)
super({ importMetaUrl: import.meta.url, tabindex: 'no-tabindex-style', ...options }, ...args)

// link behavior made accessible
if (this.hasAttribute('href')) {
Expand Down