-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: docker-compose, volumes don't overwrite UI #3205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
currently, mounting all of the working directory to the app dir in the container means that the UI built in the container at `/usr/src/app/plugins/magma` is overwritten by what is on the host. If the UI is not built on the host, the container and docker-compose will not work as expected. This change adds a volume to protect the contents of the built UI in the container from being overwritten by the host's content in `/usr/src/app/plugins/magma`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a Docker Compose issue where the host directory mount was overwriting the pre-built UI components in the container. The solution adds a named volume to protect the built UI directory from being overwritten by the host mount.
- Adds a container name for better identification
- Protects the pre-built UI directory from host mount overwrites
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@deacon-mp one copilot suggestion accepted. Let me know if you need these commits squashed. |
|
Description
currently, mounting all of the working directory to the app dir in the container means that the UI built in the container at
/usr/src/app/plugins/magma
is overwritten by what is on the host. If the UI is not built on the host, the container and docker-compose will not work as expected.This change adds a volume to protect the contents of the built UI in the container from being overwritten by the host's content in
/usr/src/app/plugins/magma
Type of change
How Has This Been Tested?
browse UI, works
Checklist: