Skip to content

Allow more customization of kes section in tenant #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 24, 2025

Conversation

killerwhile
Copy link
Contributor

@killerwhile killerwhile commented May 15, 2025

Description

This small PR extends the available values in kes objects to improve (and correct) the customzation of the kes section in the tenant helm chart.

  • Some values were hardcoded, they are now configurable
  • Some values are available in the tenant CRD, but not available in the chart
  • Some values where not searched (dug) at the right place in the values.yaml file.

Type of Change

  • Bug fix 🐛 and improvments
  • New feature 🚀
  • Breaking change 🚨
  • Documentation update 📖
  • Refactor 🔨
  • Other (please describe) ⬇️

Checklist

  • I have tested these changes
  • I have updated relevant documentation (if applicable)
  • I have added necessary unit tests (if applicable)

Test Steps

  1. Uncomment kes section in the helm/tenantvalues.yaml file
  2. Change some values
  3. run helm template
  4. Make sure the change are reflected properly

Additional Notes / Context

@killerwhile
Copy link
Contributor Author

Any more update needed from me on this one?

jiuker
jiuker previously approved these changes May 24, 2025
@jiuker jiuker self-requested a review May 24, 2025 01:41
@killerwhile
Copy link
Contributor Author

Friendly reminder. Thanks!

@jiuker
Copy link
Contributor

jiuker commented Jun 3, 2025

Could you use helm template to show if all the fields set right?

@killerwhile
Copy link
Contributor Author

killerwhile commented Jun 3, 2025

Yes, just helm templates . from the helm/tenant folder.
Defaults were already present but commented out in kes object, and my PR is only using the attributes that were already present but not used from kes object, defaulting to the old behavior for backward compatibility.

@killerwhile killerwhile force-pushed the fix/helm-chart-tenant-kes branch from a5b80ac to b14ade4 Compare June 7, 2025 15:11
@killerwhile killerwhile force-pushed the fix/helm-chart-tenant-kes branch from b14ade4 to 1174f81 Compare June 26, 2025 04:37
@killerwhile
Copy link
Contributor Author

Friendly reminder. Thanks!

@killerwhile killerwhile force-pushed the fix/helm-chart-tenant-kes branch from 1174f81 to 82580b1 Compare July 6, 2025 20:18
@killerwhile
Copy link
Contributor Author

Friendly reminder. Thanks!

@ramondeklein
Copy link
Contributor

@jiuker @cniackz Can you review and when approved, please merge it

@killerwhile
Copy link
Contributor Author

Friendly reminder. Thanks!

@ramondeklein ramondeklein merged commit 0e9a98a into minio:master Jul 24, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants