-
Notifications
You must be signed in to change notification settings - Fork 87
feat(transformers): add hunyuan v1 dense/moe (v4.57.1) #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Fzilan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Hunyuan v1 dense and MoE models. The changes include adding the model implementations, tests, and registering them in the auto classes. The implementation is a port from PyTorch and contains some porting errors, such as using .contiguous() which is not available in MindSpore and will cause runtime errors. I've also found a bug in the MoE gate logic, a potential simplification for better readability, a typo in auto-configuration, and an incorrect model ID in a docstring example. I've provided suggestions to fix these issues.
add
Add the
HunyuanV1Dense,HuanyuanV1MoEmodels, aligned with transformers v4.57.1usage
HunyuanV1Denseresults:
HuanyuanV1MoECurrently the unit tests of the modeling script pass.
performance
Experiments are tested on Ascend Atlas 800T A2 machines with mindspore 2.7.0 pynative mode,
tencent/Hunyuan-MT-7Bbf16before submitting
What's New. Here are thedocumentation guidelines