-
Couldn't load subscription status.
- Fork 88
fix[example/hunyunvideo]:HunyuanVideo is compatible with MindSpore 2.6 and 2.7 #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v0.4.0
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @iugoood, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the HunyuanVideo project's compatibility with recent MindSpore versions (2.6 and 2.7). It includes critical bug fixes such as introducing a custom GroupNorm implementation to resolve precision issues, adjusting text encoder logic for accurate hidden state retrieval, and updating key dependencies. These changes ensure the model operates correctly and efficiently within the specified MindSpore environments. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to make HunyuanVideo compatible with MindSpore 2.6 and 2.7. The changes include updating dependencies and environment configurations in the README and requirements.txt. It also introduces a custom GroupNorm class to handle data type precision issues and fixes some bugs related to argument parsing and activation function instantiation. My main concern is with the changes in hyvideo/text_encoder/__init__.py, where relying on tuple indexing to access model outputs is fragile and can lead to bugs depending on the model's configuration. I've left a comment with a suggestion for a more robust implementation.
|
|
||
| def construct(self, x: Tensor): | ||
| if self.affine: | ||
| x = group_norm(x, self.num_groups, self.weight.to(x.dtype), self.bias.to(x.dtype), self.eps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls update the inference performance on ms2.6/2.7
|
What does this PR do?
HunyuanVideo is compatible with MindSpore 2.6 and 2.7
1.example/hunyunvideo added GroupNorm class to fix the misalignment of GroupNorm precision types during model training and inference.
2. fix some bug
Fixes # (issue)
Adds # (feature)
Before submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx