Skip to content

fix(tables): Resolve compilation errors in table-related classes #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pankaj-bind
Copy link

@pankaj-bind pankaj-bind commented Jun 22, 2025

Screenshot from 2025-06-22 20-21-07
Fixing TypeScript compilation errors that were preventing the test suite from running. The issues were primarily located in the src/tables/ directory and were caused by a missing method in an abstract class and syntax errors in the Table class definition.

Description of Changes:

  1. Added Missing removeTable Method:

    • The Table.removeTable() method was calling this.tablesApiClient.removeTable(), but this method was not defined in the TablesApiClient abstract class.
    • To fix this, an abstract removeTable method has been added to tablesApiClient.ts.
    • The method has been implemented in tablesRestApiClient.ts, where it calls the existing deleteTable method to maintain consistent functionality.
  2. Corrected Syntax in table.ts:

    • The insert method and its JSDoc comment block were incorrectly placed outside the Table class, causing multiple syntax and compilation errors.
    • This has been corrected by moving the entire insert method block inside the Table class.
    • Malformed comments and extra closing braces have also been removed to ensure the file is syntactically correct.
npm test -- tests/databases/databasesRestApiClient.test.ts

Screenshot from 2025-06-22 20-29-18

Copy link

Unable to Process PR Review

The author of this PR does not exist on Entelligence Dashboard. Please add the user to Entelligence AI here to enable reviews for this user.

Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@pankaj-bind pankaj-bind changed the title Resolve compilation errors in table-related classes fix(tables): Resolve compilation errors in table-related classes Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant