Skip to content

♻️ replace pikepdf with pypdfium2 #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 24, 2024
Merged

♻️ replace pikepdf with pypdfium2 #226

merged 10 commits into from
May 24, 2024

Conversation

sebastianMindee
Copy link
Collaborator

@sebastianMindee sebastianMindee commented Mar 7, 2024 •
edited
Loading

Description

Notes:

  • no type declarations for mypy on this lib, unfortunately :/
  • Keeping this as draft since licensing isn't fully sorted out.

Related Issue

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

@sebastianMindee sebastianMindee marked this pull request as draft March 7, 2024 18:04
@sebastianMindee sebastianMindee marked this pull request as ready for review March 11, 2024 11:07
matthiasmindee
matthiasmindee requested changes Mar 14, 2024
View reviewed changes
matthiasmindee
matthiasmindee approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@matthiasmindee matthiasmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cyril FiggiSUPER

@sebastianMindee sebastianMindee requested a review from ianardee May 23, 2024 15:39
@sebastianMindee sebastianMindee merged commit f74bb46 into main May 24, 2024
22 checks passed
@sebastianMindee sebastianMindee deleted the replace-pikepdf branch May 24, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashirmindee bashirmindee bashirmindee approved these changes

@matthiasmindee matthiasmindee matthiasmindee approved these changes

@ianardee ianardee ianardee approved these changes

@thentgesMindee thentgesMindee Awaiting requested review from thentgesMindee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebastianMindee @bashirmindee @matthiasmindee @ianardee