fix: fix typing in theme overriding #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This: `{ [K in keyof typeof HighlightSubject]?: string } `
- gives a type with UPPER CASE keys, but the default theme and how it's
resolved via `TOKEN_TYPE_TO_HIGHLIGHT` expects the values, i.e.
lower case
- string is wrong type as a `StyleFunction` is expected and then called
I.e. the types suggest this
`new SqlHighlighter({ RESERVED: 'red' })`
but this has no effect. To get it to work w/o this fix:
`new SqlHighlighter({ reserved: c.red.bold } as any)`
Pull Request Test Coverage Report for Build 15862431405Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
{ [K in keyof typeof HighlightSubject]?: string }TOKEN_TYPE_TO_HIGHLIGHTexpects the values, i.e. lower caseStyleFunctionis expected and then calledI.e. the types suggest this
new SqlHighlighter({ RESERVED: 'red' })but this has no effect. To get it to work w/o this fix:new SqlHighlighter({ reserved: c.red.bold } as any)