Enable Compose Hot Reload for Desktop sample #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Compose hot-reload support for the desktop sample and updates build tooling.
- Adds the Foojay resolver plugin to settings.gradle.kts
- Bumps the version-catalog plugin from 0.3.7 to 0.3.8
- Enables hot reload in the desktop sample’s gradle.properties
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| settings.gradle.kts | Adds org.gradle.toolchains.foojay-resolver plugin and updates version-catalog |
| sample/desktop/gradle.properties | Enables Compose hot reload via a new property |
Comments suppressed due to low confidence (1)
sample/desktop/gradle.properties:2
- [nitpick] Consider using a hyphenated key (
com.mikepenz.hot-reload.enabled) to align with the dash-separated naming convention used by other plugin properties.
com.mikepenz.hotreload.enabled=true
| com.mikepenz.binary-compatibility-validator.enabled=false | ||
| com.mikepenz.hotreload.enabled=true |
There was a problem hiding this comment.
[nitpick] Add a comment above this property explaining that it enables Compose hot-reload for the desktop sample, so future maintainers understand its purpose.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change