Skip to content

Add pull request template | Update security e-mail #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2025

Conversation

mikepenz
Copy link
Owner

No description provided.

@mikepenz mikepenz requested a review from Copilot May 25, 2025 12:17
@mikepenz mikepenz added the other label May 25, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the project’s security contact information and adds a standard GitHub pull request template

  • Change the security vulnerability report email in SECURITY.md
  • Introduce a new .github/PULL_REQUEST_TEMPLATE.md with sections for description, testing, and a checklist

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
SECURITY.md Updated vulnerability reporting email and list formatting
.github/PULL_REQUEST_TEMPLATE.md Added a PR template covering description, tests, and checklist

Comment on lines +9 to +10
Please report (suspected) security vulnerabilities to opensource-sec@mikepenz.dev. If the issue is
confirmed, we will release a patch as soon as possible depending on complexity.
Copy link
Preview

Copilot AI May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence is split across two lines and the leading '-' was removed, breaking list formatting. Consider merging this into one line and re-adding the '-' for consistent Markdown list styling.

Suggested change
Please report (suspected) security vulnerabilities to opensource-sec@mikepenz.dev. If the issue is
confirmed, we will release a patch as soon as possible depending on complexity.
Please report (suspected) security vulnerabilities to opensource-sec@mikepenz.dev. If the issue is confirmed, we will release a patch as soon as possible depending on complexity.

Copilot uses AI. Check for mistakes.

Comment on lines +9 to +10
Please report (suspected) security vulnerabilities to opensource-sec@mikepenz.dev. If the issue is
confirmed, we will release a patch as soon as possible depending on complexity.
Copy link
Preview

Copilot AI May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This continuation line should be part of the same bullet; remove the extra line break to keep the message clear and formatted as a single list item.

Suggested change
Please report (suspected) security vulnerabilities to opensource-sec@mikepenz.dev. If the issue is
confirmed, we will release a patch as soon as possible depending on complexity.
Please report (suspected) security vulnerabilities to opensource-sec@mikepenz.dev. If the issue is confirmed, we will release a patch as soon as possible depending on complexity.

Copilot uses AI. Check for mistakes.

@@ -0,0 +1,32 @@
## Description
Copy link
Preview

Copilot AI May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a top-level title or comment at the very top (e.g., # Pull Request Template) to clarify this file’s purpose when browsing the repo.

Copilot uses AI. Check for mistakes.

@mikepenz mikepenz merged commit 77b4576 into develop May 25, 2025
3 checks passed
@mikepenz mikepenz deleted the feature/contribution branch May 25, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant