-
-
Notifications
You must be signed in to change notification settings - Fork 47
dev -> main #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev -> main #398
Conversation
Collecting with `Flow.collectAsStateWithLifecycle` will always emit the initial value passed in, in this case, momentarily showing `State.Loading` again every time the collection restarts. Using `StateFlow.collectAsStateWithLifecycle` instead avoids this problem, as its initial value will be the current `value` of the `StateFlow`, which can already be `State.Success` if the parsing was completed earlier.
Fix VM example in README
```diff diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072910</lastUpdated> --- > <lastUpdated>20250419072637</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-android/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-android/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072906</lastUpdated> --- > <lastUpdated>20250419072633</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-code/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-code/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072917</lastUpdated> --- > <lastUpdated>20250419072645</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-code-android/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-code-android/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072913</lastUpdated> --- > <lastUpdated>20250419072641</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-code-iosarm64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-code-iosarm64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072914</lastUpdated> --- > <lastUpdated>20250419072641</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-code-iossimulatorarm64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-code-iossimulatorarm64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072915</lastUpdated> --- > <lastUpdated>20250419072642</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-code-iosx64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-code-iosx64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072915</lastUpdated> --- > <lastUpdated>20250419072642</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-code-js/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-code-js/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072916</lastUpdated> --- > <lastUpdated>20250419072643</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-code-jvm/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-code-jvm/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072917</lastUpdated> --- > <lastUpdated>20250419072644</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-code-macosarm64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-code-macosarm64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072918</lastUpdated> --- > <lastUpdated>20250419072645</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-code-macosx64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-code-macosx64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072918</lastUpdated> --- > <lastUpdated>20250419072646</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-code-wasm-js/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-code-wasm-js/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072919</lastUpdated> --- > <lastUpdated>20250419072647</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-coil2/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-coil2/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072919</lastUpdated> --- > <lastUpdated>20250419072647</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-coil2-android/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-coil2-android/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072919</lastUpdated> --- > <lastUpdated>20250419072647</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-coil2-jvm/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-coil2-jvm/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072919</lastUpdated> --- > <lastUpdated>20250419072647</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-coil3/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-coil3/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072925</lastUpdated> --- > <lastUpdated>20250419072653</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-coil3-android/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-coil3-android/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072921</lastUpdated> --- > <lastUpdated>20250419072649</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-coil3-iosarm64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-coil3-iosarm64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072922</lastUpdated> --- > <lastUpdated>20250419072650</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-coil3-iossimulatorarm64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-coil3-iossimulatorarm64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072922</lastUpdated> --- > <lastUpdated>20250419072650</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-coil3-iosx64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-coil3-iosx64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072923</lastUpdated> --- > <lastUpdated>20250419072651</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-coil3-js/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-coil3-js/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072924</lastUpdated> --- > <lastUpdated>20250419072652</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-coil3-jvm/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-coil3-jvm/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072925</lastUpdated> --- > <lastUpdated>20250419072653</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-coil3-macosarm64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-coil3-macosarm64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072925</lastUpdated> --- > <lastUpdated>20250419072654</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-coil3-macosx64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-coil3-macosx64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072926</lastUpdated> --- > <lastUpdated>20250419072654</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-coil3-wasm-js/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-coil3-wasm-js/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072927</lastUpdated> --- > <lastUpdated>20250419072655</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-iosarm64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-iosarm64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072907</lastUpdated> --- > <lastUpdated>20250419072634</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-iossimulatorarm64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-iossimulatorarm64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072907</lastUpdated> --- > <lastUpdated>20250419072634</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-iosx64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-iosx64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072907</lastUpdated> --- > <lastUpdated>20250419072635</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-js/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-js/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072909</lastUpdated> --- > <lastUpdated>20250419072636</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-jvm/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-jvm/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072909</lastUpdated> --- > <lastUpdated>20250419072637</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m2/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m2/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072932</lastUpdated> --- > <lastUpdated>20250419072700</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m2-android/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m2-android/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072928</lastUpdated> --- > <lastUpdated>20250419072657</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m2-iosarm64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m2-iosarm64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072929</lastUpdated> --- > <lastUpdated>20250419072657</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m2-iossimulatorarm64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m2-iossimulatorarm64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072929</lastUpdated> --- > <lastUpdated>20250419072658</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m2-iosx64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m2-iosx64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072929</lastUpdated> --- > <lastUpdated>20250419072658</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m2-js/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m2-js/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072930</lastUpdated> --- > <lastUpdated>20250419072659</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m2-jvm/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m2-jvm/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072931</lastUpdated> --- > <lastUpdated>20250419072700</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m2-macosarm64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m2-macosarm64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072932</lastUpdated> --- > <lastUpdated>20250419072701</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m2-macosx64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m2-macosx64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072933</lastUpdated> --- > <lastUpdated>20250419072701</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m2-wasm-js/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m2-wasm-js/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072934</lastUpdated> --- > <lastUpdated>20250419072702</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m3/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m3/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072939</lastUpdated> --- > <lastUpdated>20250419072707</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m3-android/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m3-android/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072936</lastUpdated> --- > <lastUpdated>20250419072704</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m3-iosarm64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m3-iosarm64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072936</lastUpdated> --- > <lastUpdated>20250419072704</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m3-iossimulatorarm64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m3-iossimulatorarm64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072937</lastUpdated> --- > <lastUpdated>20250419072705</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m3-iosx64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m3-iosx64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072937</lastUpdated> --- > <lastUpdated>20250419072705</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m3-js/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m3-js/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072938</lastUpdated> --- > <lastUpdated>20250419072706</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m3-jvm/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m3-jvm/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072939</lastUpdated> --- > <lastUpdated>20250419072707</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m3-macosarm64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m3-macosarm64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072940</lastUpdated> --- > <lastUpdated>20250419072708</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m3-macosx64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m3-macosx64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072940</lastUpdated> --- > <lastUpdated>20250419072708</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-m3-wasm-js/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-m3-wasm-js/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072941</lastUpdated> --- > <lastUpdated>20250419072709</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-macosarm64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-macosarm64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072910</lastUpdated> --- > <lastUpdated>20250419072638</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-macosx64/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-macosx64/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072911</lastUpdated> --- > <lastUpdated>20250419072638</lastUpdated> diff --color=auto -r mikepenz-before/multiplatform-markdown-renderer-wasm-js/maven-metadata-local.xml mikepenz-after/multiplatform-markdown-renderer-wasm-js/maven-metadata-local.xml 11c11 < <lastUpdated>20250419072912</lastUpdated> --- > <lastUpdated>20250419072639</lastUpdated> ```
Remove unsued main source sets and AndroidManifest files
Fix deprecation warning for aboutlibs in iOS sample
Compose 1.8.0 / Compose Multiplatform 1.8.0-rc01
…ion` (e.g. preview) - FIX #385
Make markdown parsing `immediate` if `LocalInspectionMode` is true
…plugin Update to AboutLibraries 12.1.0-rc02
Add export configuration for library definitions
AboutLibraries `12.1.0-rc03`
Reorder `markdownAnnotator` function arguments
- FIX #391 - fix order of nested block quotes wrong
Improve BlockQuotes
Add way to specify custom inline content
- update to ktor 3.1.3 - update to aboutlibraries 12.1.2
Update to Compose Multiplatform 1.8.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the API definitions across multiple modules to add support for inline content in Markdown rendering while also adjusting generated lambda names. In addition, the PR includes dependency and version bumps, changes in Gradle wrapper configuration, and minor updates to build scripts and documentation.
Reviewed Changes
Copilot reviewed 60 out of 60 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
multiplatform-markdown-renderer/api/* | Updated API signatures to include inline content and revised lambda method names |
multiplatform-markdown-renderer-m2/* and m3/* | Added inline content parameters and removed empty AndroidManifest.xml files |
gradlew and gradlew.bat | Modified command-line invocation to use the -jar flag rather than CLASSPATH assignment |
build.gradle.kts, gradle/*, gradle.properties, libs.versions.toml | Bumped versions and updated dependency exclusions and Gradle distribution URL |
README.md, MIGRATION.md | Updated usage snippet and added migration notes for version 0.34.0 |
Comments suppressed due to low confidence (2)
multiplatform-markdown-renderer-m3/src/main/AndroidManifest.xml:1
- The removal of the empty AndroidManifest.xml file should be confirmed as intentional; add a note or update documentation if this change affects module configuration.
<?xml version="1.0" encoding="utf-8"?>
multiplatform-markdown-renderer-coil3/build.gradle.kts:16
- The coil dependency is declared twice, once directly and once with an exclusion. Consider removing the redundant declaration to avoid potential dependency conflicts.
commonMainApi(libs.coil.core)
set CLASSPATH= | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment explaining why the CLASSPATH is intentionally set to an empty value (with the jar supplied via the -jar flag) would improve future maintainability.
set CLASSPATH= | |
@rem The CLASSPATH is intentionally set to an empty value because the -jar flag | |
@rem in the Java command below overrides it, using the classpath specified in | |
@rem the JAR's manifest instead. | |
set CLASSPATH= |
Copilot uses AI. Check for mistakes.
No description provided.