Improve typing for Trimesh objects #2472
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattTheCuber
commented
Oct 18, 2025
| def export( | ||
| self, | ||
| file_obj=None, | ||
| file_obj: Loadable = None, |
There was a problem hiding this comment.
This type hint is making tests/test_export.py::ExportTest::test_buffered_random fail with beartype enabled. I tried a bunch of different fixes, but I don't understand why it's not working since the test uses io.BufferedRandom which is a superclass of Loadable (BinaryIO)...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a lot of missing typing to methods and properties in the
Trimeshclass. Additionally, this PR updates a bunch of docstrings that were missing information.