fix: plugin cache miss for some existing lazygits #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two possible problems were fixed: - after force_quitting lazygit, the cache was not cleared, which sometimes caused problems when trying to open a new lazygit in the same directory - sometimes the lazygit cache was bypassed because snacks reported it being `closed`, but it was actually still open. I added strict assertions to ensure that the cache is always respected. Also refactored the cache into its own module, and added some accessors.
|
See #225 (comment) to understand why the build fails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two possible problems were fixed:
closed, but it was actually still open.I added strict assertions to ensure that the cache is always respected.
Also refactored the cache into its own module, and added some accessors.