Skip to content

Fix broken unit tests in time-planning-pn components #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2025
Merged

Fix broken unit tests in time-planning-pn components #1122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39bc098
Initial plan
Copilot Oct 19, 2025
fed8b75
Fix broken unit tests in time-planning-pn components
Copilot Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ents/plannings/time-planning-actions/assigned-site/assigned-site-dialog.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,9 @@ describe('AssignedSiteDialogComponent', () => {
component.copyBreakSettings('monday');

const mondayBreak = component.assignedSiteForm.get('autoBreakSettings')?.get('monday');
expect(mondayBreak?.get('breakMinutesDivider')?.value).toBe(480);
expect(mondayBreak?.get('breakMinutesPrDivider')?.value).toBe(30);
expect(mondayBreak?.get('breakMinutesUpperLimit')?.value).toBe(60);
expect(mondayBreak?.get('breakMinutesDivider')?.value).toBe('08:00');
expect(mondayBreak?.get('breakMinutesPrDivider')?.value).toBe('00:30');
expect(mondayBreak?.get('breakMinutesUpperLimit')?.value).toBe('01:00');
});

it('should handle missing global settings gracefully', () => {
Expand Down
8 changes: 4 additions & 4 deletions ...ponents/plannings/time-planning-actions/download-excel/download-excel-dialog.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {Component, Inject, Input, OnDestroy, OnInit} from '@angular/core';
import {Subscription} from 'rxjs';
import {EMPTY, Subscription} from 'rxjs';
import {MatDatepickerInputEvent} from '@angular/material/datepicker';
import {SiteDto} from 'src/app/common/models';
import {
Expand Down Expand Up @@ -66,7 +66,7 @@ export class DownloadExcelDialogComponent implements OnInit, OnDestroy {
.pipe(catchError(
(error, caught) => {
this.toastrService.error('Error downloading report');
return caught;
return EMPTY;
}))
.subscribe(
(data) => {
Expand All @@ -83,9 +83,9 @@ export class DownloadExcelDialogComponent implements OnInit, OnDestroy {
this.downloadReportSub$ = this.workingHoursService
.downloadReportAllWorkers(model)
.pipe(catchError(
(caught) => {
(error) => {
this.toastrService.error('Error downloading report');
return caught;
return EMPTY;
}))
.subscribe(
(data) => {
Expand Down
Loading