Skip to content

Fixes authentication on every request when using the AddBatchRequestStepAsync overload #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 28, 2025

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Jan 28, 2025

Closes microsoftgraph/msgraph-sdk-dotnet#2774

Authentication provider is unnecessarilly invoked repeatedly to set the Auth header which is unnecessary in the batch message. In the event that the message isn't in the cash this can cause increased execution for a task that is unneeded.

Microsoft Reviewers: Open in CodeFlow

@andrueastman andrueastman requested a review from a team as a code owner January 28, 2025 09:13
@andrueastman andrueastman force-pushed the andrueastman/fixBatchPerf branch from bb6e3c2 to 86e9ad3 Compare January 28, 2025 09:26
…` method due to the client trying to authenticate the request on conversion
@andrueastman andrueastman force-pushed the andrueastman/fixBatchPerf branch from 86e9ad3 to a5b3950 Compare January 28, 2025 09:29
baywet
baywet previously approved these changes Jan 28, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@andrueastman andrueastman merged commit e1fdb11 into main Jan 28, 2025
9 of 10 checks passed
@andrueastman andrueastman deleted the andrueastman/fixBatchPerf branch January 28, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a batch request step should not authenticate the request
2 participants