Skip to content

fix: resolved error handling of larger batch request message #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 10, 2024
Merged

fix: resolved error handling of larger batch request message #916

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c78b39d
fix: resolved handling of larger batch request message
Sep 10, 2024
7da16f7
cleanup a bunch of unused constants
Sep 10, 2024
f15167a
pr review feedback.
Sep 10, 2024
41517b2
Update src/Microsoft.Graph.Core/Requests/BatchRequestBuilder.cs
andrueastman Sep 10, 2024
b92392e
resolve compile error.
Sep 10, 2024
c479702
chore: removes redundant check
baywet Sep 10, 2024
85472de
pass cancellation token
Sep 10, 2024
32373ec
Merge remote-tracking branch 'origin/andrueastman/fixBatch' into andr…
Sep 10, 2024
f29e4cd
fix: moves parse async out of the condition since it always accepts a…
baywet Sep 10, 2024
2213321
fix: adds missing cancellation token parameter
baywet Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Microsoft.Graph.Core/Requests/BatchRequestBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ private static async Task ThrowIfFailedResponseAsync(HttpResponseMessage httpRes
{
if (httpResponseMessage.IsSuccessStatusCode) return;

if (CoreConstants.MimeTypeNames.Application.Json.Equals(httpResponseMessage.Content?.Headers?.ContentType?.MediaType, StringComparison.OrdinalIgnoreCase))
var contentTypeString = httpResponseMessage.Content?.Headers?.ContentType?.MediaType is { } contentTypeMediaType && !string.IsNullOrEmpty(contentTypeMediaType) ? contentTypeMediaType : string.Empty;
if (httpResponseMessage.Content != null && contentTypeString.StartsWith(CoreConstants.MimeTypeNames.Application.Json, StringComparison.OrdinalIgnoreCase))
{
using var responseContent = await httpResponseMessage.Content.ReadAsStreamAsync().ConfigureAwait(false);
using var document = await JsonDocument.ParseAsync(responseContent).ConfigureAwait(false);
Expand Down
Loading