Skip to content

fix: resolve trimming warnings in project #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2024
Merged

fix: resolve trimming warnings in project #903

merged 2 commits into from
Sep 4, 2024

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Aug 30, 2024 •
edited
Loading

This PR resolves all trimming warnings in the project

  • Adding relevant DynamicallyAccessedMembers attributes where necessarry and Removing calls of object.GetType() (as this results in unresolvable trimming warnings)
  • Add a trimming validation project and add a validation build step in the pipeline.
Microsoft Reviewers: Open in CodeFlow

@andrueastman andrueastman force-pushed the andrueastman/fixTrimmingWarnings branch 3 times, most recently from ad9c0ed to 4b47b57 Compare August 30, 2024 08:42
@andrueastman andrueastman marked this pull request as ready for review August 30, 2024 10:06
@andrueastman andrueastman requested a review from a team as a code owner August 30, 2024 10:06
@andrueastman andrueastman enabled auto-merge August 30, 2024 10:06
baywet
baywet reviewed Aug 30, 2024
View reviewed changes
@andrueastman andrueastman force-pushed the andrueastman/fixTrimmingWarnings branch from 38f4558 to e326ed5 Compare August 30, 2024 14:04
@andrueastman andrueastman requested a review from baywet August 30, 2024 14:33
baywet
baywet reviewed Aug 30, 2024
View reviewed changes
@andrueastman andrueastman self-assigned this Sep 3, 2024
@andrueastman andrueastman marked this pull request as draft September 3, 2024 08:36
This was referenced Sep 4, 2024
Merged
Merged
Merged
@andrueastman andrueastman force-pushed the andrueastman/fixTrimmingWarnings branch from aea16cd to ea690d3 Compare September 4, 2024 10:52
baywet
baywet reviewed Sep 4, 2024
View reviewed changes
@andrueastman andrueastman force-pushed the andrueastman/fixTrimmingWarnings branch from be57055 to 6036cf7 Compare September 4, 2024 11:42
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
79.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@andrueastman andrueastman marked this pull request as ready for review September 4, 2024 11:47
@andrueastman andrueastman merged commit c7bb7ca into main Sep 4, 2024
10 of 11 checks passed
@andrueastman andrueastman deleted the andrueastman/fixTrimmingWarnings branch September 4, 2024 11:52
@andrueastman andrueastman mentioned this pull request Sep 4, 2024
Merged
@andrueastman andrueastman mentioned this pull request Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees

@andrueastman andrueastman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrueastman @baywet