Skip to content

fix(mgt-react): migrates to modern React rendering #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tobi1220
Copy link
Contributor

@tobi1220 tobi1220 commented May 27, 2025

Closes #3412

PR Type

Bugfix

Description of the changes

The package mgt-react doesn't work under React 19 because it uses React's deprecated render() (docs) function to render its components. From React 18 and onward , the function createRoot() (docs) should be used. This PR applies the simple changes demonstrated in React's official migration guide. Thus, this will drop support for the deprecated React 17.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@tobi1220 tobi1220 requested a review from a team as a code owner May 27, 2025 22:41
Copy link
Contributor

Thank you for creating a Pull Request @@tobi1220.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@tobi1220
Copy link
Contributor Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[QUESTION]: Is there planned support for React 19?
1 participant