Skip to content

[date] Fix installation #32772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2023
Merged

[date] Fix installation #32772

merged 2 commits into from
Jul 26, 2023

Conversation

@xiaozhuai
Copy link
Contributor

@xiaozhuai xiaozhuai commented Jul 26, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Fix #32765

@xiaozhuai xiaozhuai changed the title Dev date [date] Fix installation Jul 26, 2023
@xiaozhuai
Copy link
Contributor Author

xiaozhuai commented Jul 26, 2023 •
edited
Loading

The upstram didn't install some header files, such as iso_week.h.
There is a pr HowardHinnant/date#503 three years ago, but it didn't get merged.
This fix is a workaround.

@xiaozhuai xiaozhuai mentioned this pull request Jul 26, 2023
Closed
@BillyONeal BillyONeal merged commit c269756 into microsoft:master Jul 26, 2023
@BillyONeal
Copy link
Member

BillyONeal commented Jul 26, 2023

Thanks!

@jimwang118 jimwang118 self-requested a review July 27, 2023 01:51
@jimwang118 jimwang118 self-assigned this Jul 27, 2023
@jimwang118 jimwang118 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Jul 27, 2023
@xiaozhuai xiaozhuai deleted the dev-date branch July 27, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimwang118 jimwang118 Awaiting requested review from jimwang118

Assignees

@jimwang118 jimwang118

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[date] Looks like current port implementation is broken

3 participants

@xiaozhuai @BillyONeal @jimwang118