Fix nil host with watch and incremental #1455
Merged
+50
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1453
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #1453 where the watcher would have a nil host when using both --watch and --incremental flags with a tsconfig.json file. The fix ensures the compiler host is always initialized regardless of whether a config file is present.
- Removes conditional host initialization that was causing nil pointer issues
- Adds test coverage for the watch + incremental + tsconfig combination
- Updates baseline with expected output for the new test scenario
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/execute/watcher.go | Removes the conditional check that prevented host initialization when a config file was present |
| internal/execute/tscwatch_test.go | Adds a new test case covering the watch + tsconfig + incremental scenario |
| testdata/baselines/reference/tscWatch/commandLineWatch/watch-with-tsconfig-and-incremental.js | Baseline output for the new test case showing successful compilation |
| if w.configFileName == "" { | ||
| w.host = compiler.NewCompilerHost(w.sys.GetCurrentDirectory(), w.sys.FS(), w.sys.DefaultLibraryPath(), nil) | ||
| } | ||
| w.host = compiler.NewCompilerHost(w.sys.GetCurrentDirectory(), w.sys.FS(), w.sys.DefaultLibraryPath(), nil) |
There was a problem hiding this comment.
The host initialization is now unconditional, but when w.configFileName is not empty, the host might need to be configured differently based on the config file settings. Consider if the host should use configuration-specific settings when a config file is present.
Copilot uses AI. Check for mistakes.
jakebailey
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1453