Always include spelling suggestions in name errors #1440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahejlsberg
requested review from
Copilot and
jakebailey
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR implements a change to always include spelling suggestions in TypeScript name error messages. The modification enhances error messages by providing helpful suggestions when identifiers cannot be found, upgrading error codes from TS2304 ("Cannot find name") to TS2552 ("Cannot find name ... Did you mean ...?") when appropriate suggestions are available.
- Replaces generic "Cannot find name" errors with more helpful "Did you mean" suggestions
- Adds related error information showing where suggested alternatives are declared
- Maintains consistent error messaging across TypeScript conformance test cases
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Multiple .errors.txt files | Updated baseline error messages to include spelling suggestions for undefined identifiers |
| Multiple .errors.txt.diff files | Show the transition from TS2304 to TS2552 error codes with spelling suggestions |
jakebailey
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1383.