Skip to content

Enable HangDumpTests on macOS #5522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

Youssef1313
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.95%. Comparing base (01f5c5c) to head (9aeca19).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...ensions.HangDump/HangDumpProcessLifetimeHandler.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5522      +/-   ##
==========================================
- Coverage   73.98%   73.95%   -0.04%     
==========================================
  Files         603      603              
  Lines       36433    36433              
==========================================
- Hits        26955    26944      -11     
- Misses       9478     9489      +11     
Flag Coverage Δ
Debug 73.95% <0.00%> (-0.04%) ⬇️
integration 73.95% <0.00%> (-0.04%) ⬇️
production 73.95% <0.00%> (-0.04%) ⬇️
unit 73.95% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ensions.HangDump/HangDumpProcessLifetimeHandler.cs 53.94% <0.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nohwnd
Copy link
Member

nohwnd commented Apr 29, 2025

Is this to repro the problem with the netclient from dotnet/diagnostics?

@Youssef1313
Copy link
Member Author

@nohwnd Yup

@Youssef1313
Copy link
Member Author

@nohwnd
Copy link
Member

nohwnd commented May 19, 2025

Do we see the issue on net6 and older only?

According to the note in the link below that env variable is no longer necessary, and I did not find other mentions of it that would document it with the DOTNET_ prefix, which is what all new env variables do.

https://github.com/dotnet/runtime/blob/main/docs/design/coreclr/botr/xplat-minidump-generation.md#macos

@Youssef1313
Copy link
Member Author

Hmm, indeed. 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants