.Net Processes - Expose OnError Event Handling #9187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crickman
added
PR: ready for review
alliscode
reviewed
Oct 9, 2024
alliscode
approved these changes
Oct 9, 2024
esttenorio
reviewed
Oct 9, 2024
esttenorio
approved these changes
Oct 9, 2024
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Enabled support for function-specific error-handler step in this PR: #9187 Fixes: #9291 This change provides the ability to define a _process scoped_ error handler (as opposed to function specific). When a function-scoped error-handler is defined, it will take precedence. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ```c# ProcessBuilder process = new(nameof(ProcessFunctionErrorHandledAsync)); ProcessStepBuilder errorStep = process.AddStepFromType<ErrorStep>(); process.OnError().SendEventTo(new ProcessFunctionTargetBuilder(errorStep)); class ErrorStep : KernelProcessStep { [KernelFunction] public void GlobalErrorHandler(Exception exception) { } } ``` **Notes:** - Switch error handler from passing `Exception` object to a `KernelProcessError` to satisfy serialization expectations - Normalized namespaces for `Internal` shared code - Introduced shared `ProcessConstants` file - Opportunistically converted some `List` creation to `Array` - Opportunistically included parameter name in some `Verify` assertions. - Opportunistically removed a extraneous _not-null_ directives (`!`) - Verified DAPR error handling in demo app (`True` means the expected error handler was invoked): <img width="449" alt="image" src="https://github.com/user-attachments/assets/2d987378-edd2-4c9f-92dd-cf112888b8b0"> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Introduce support for
.OnErrorwith parity to.OnResultDescription
Contribution Checklist