Skip to content

Python: removed underscore in .env for open_ai #7625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

cvaisnor
Copy link
Contributor

@cvaisnor cvaisnor commented Aug 2, 2024

Description

When running the getting-started Python notebooks, the user is instructed to create and populate their own .env file. The values for the OpenAI specifications included an underscore between 'open' and 'ai'. This led to an error when initializing the chat/text/embedding model service.

I have removed the underscore from the base .env files, README, and in the evaluate_with_prompt_flow.py script when reading from the .env file.

@cvaisnor cvaisnor requested a review from a team as a code owner August 2, 2024 20:39
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel documentation labels Aug 2, 2024
@github-actions github-actions bot changed the title removed underscore in .env for open_ai Python: removed underscore in .env for open_ai Aug 2, 2024
@cvaisnor
Copy link
Contributor Author

cvaisnor commented Aug 2, 2024

@microsoft-github-policy-service agree

@moonbox3 moonbox3 enabled auto-merge August 2, 2024 20:55
@moonbox3 moonbox3 added this pull request to the merge queue Aug 2, 2024
Merged via the queue into microsoft:main with commit ac1613a Aug 2, 2024
24 of 25 checks passed
@cvaisnor cvaisnor deleted the fix-OpenAI-naming-scheme branch August 2, 2024 21:19
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
### Description

When running the getting-started Python notebooks, the user is
instructed to create and populate their own .env file. The values for
the OpenAI specifications included an underscore between 'open' and
'ai'. This led to an error when initializing the chat/text/embedding
model service.

I have removed the underscore from the base .env files, README, and in
the evaluate_with_prompt_flow.py script when reading from the .env file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation python Pull requests for the Python Semantic Kernel samples
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants