-
Notifications
You must be signed in to change notification settings - Fork 4k
Python: Update chat history channel to produce the correct messages with a visibility bool #7619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
moonbox3
merged 9 commits into
microsoft:main
from
moonbox3:agent_chat_history_channel_update
Aug 5, 2024
Merged
Python: Update chat history channel to produce the correct messages with a visibility bool #7619
moonbox3
merged 9 commits into
microsoft:main
from
moonbox3:agent_chat_history_channel_update
Aug 5, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sibility bool. Update tests. Upgrade openai to 1.37.1
Python Test Coverage Report
Python Unit Test Overview
|
TaoChenOSU
approved these changes
Aug 2, 2024
crickman
approved these changes
Aug 5, 2024
alliscode
approved these changes
Aug 5, 2024
…x3/semantic-kernel into agent_chat_history_channel_update
TaoChenOSU
approved these changes
Aug 5, 2024
eavanvalkenburg
approved these changes
Aug 5, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…ith a visibility bool (microsoft#7619) ### Motivation and Context To align with the dotnet ChatHistoryChannel, there needs to be an update to the Python ChatHistoryChannel that properly handles the invoked message via a queue. This allows the final messages to be produced (as they sometimes may contain function call content or function result content). The messages are also produced with an `is_visibile` bool. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description This PR: - updates the chat history channel to implement the queue that handles ChatMessageContent types and the `is_visible` bool to the caller. - This change requires the use of a set and thus an implementation of a `__hash__` method for some content types so we know we're not adding/handling duplicate messages. - Upgrades OpenAI package to 1.37.1 (supersedes a previous Dependabot PR doing the same) - Updates unit tests for ChatHistoryChannel based on the new code to maintain 100% coverage. - Adds a missing `parallel_tool_calls` bool in the Run object of agent unit tests related to the upgrade to OpenAI 1.37.1. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Chris <66376200+crickman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
To align with the dotnet ChatHistoryChannel, there needs to be an update to the Python ChatHistoryChannel that properly handles the invoked message via a queue. This allows the final messages to be produced (as they sometimes may contain function call content or function result content). The messages are also produced with an
is_visibile
bool.Description
This PR:
is_visible
bool to the caller.__hash__
method for some content types so we know we're not adding/handling duplicate messages.parallel_tool_calls
bool in the Run object of agent unit tests related to the upgrade to OpenAI 1.37.1.Contribution Checklist