Skip to content

.Net: Add AssemblyAI file service Remake from #5964 #6406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

RogerBarreto
Copy link
Member

Motivation and Context

Description

Contribution Checklist

@RogerBarreto RogerBarreto requested a review from a team as a code owner May 27, 2024 09:38
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels May 27, 2024
@RogerBarreto RogerBarreto changed the title .Net Assembly AI PR Remake #5964 .Net: Add AssemblyAI file service Remake from #5964 May 27, 2024
@RogerBarreto RogerBarreto self-assigned this May 29, 2024
@RogerBarreto
Copy link
Member Author

@Swimburger, added minor changes to overall code.

  • Stopped using JsonDocument in favor of JsonElement for performance
  • Changed structure from Files to Services, all public services should be in the root namespace.
  • Changes Client to be Core in line with our other connectors.
  • Update Namespaces on UnitTests.
  • Sealing specialized class.

@Swimburger
Copy link

Those changes look great. I didn't know about the perf difference, thanks for sharing and updating!

@RogerBarreto RogerBarreto merged commit 886053d into microsoft:feature-connectors-assemblyai Jun 6, 2024
10 checks passed
@RogerBarreto RogerBarreto deleted the features/add-assembly-ai-fileclient branch February 13, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants