-
Notifications
You must be signed in to change notification settings - Fork 4k
Python: Fix schema handling. Fix function result return for type list. #6370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eavanvalkenburg
approved these changes
May 22, 2024
… plugins. Remove unused kernel json schema class.
…on result return for type string if not kernel content. Add retry logic on FC stepwise int test. Add unit test for function str return type.
alliscode
approved these changes
May 23, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
microsoft#6370) ### Motivation and Context Building the tools json payload from the kernel parameter metadata wasn't properly including an object of type `array`. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description Correctly include the object type `array` so that the tool call doesn't return a bad request. Add unit tests. - Closes microsoft#6367 - Closes microsoft#6360 - Fixes the FunctionResult return for a type string -- if the FunctionResult is of type KernelContent then return the first element of the list, otherwise return the complete list. - Fix the kernel function from method to include the proper type_object for the return parameter so that the schema can be created properly. - Add retry logic for a sometimes flaky function calling stepwise planner integration test. - Add a check during function calling that makes sure the model is returning the proper number of arguments based on how many function arguments are required. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Building the tools json payload from the kernel parameter metadata wasn't properly including an object of type
array
.Description
Correctly include the object type
array
so that the tool call doesn't return a bad request. Add unit tests.Contribution Checklist