.Net: Add Updated Memory Connector ADR and IMemoryRecordService interface with related classes. #6364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith related classes.
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
…of operation and improves consistency with future collection interface design.
|
LGTM |
dluc
reviewed
May 28, 2024
dluc
reviewed
May 28, 2024
westey-m
changed the title
dotnet/src/SemanticKernel.Abstractions/Memory/MemoryRecordAttributes/KeyAttribute.cs
Outdated
Show resolved
Hide resolved
markwallace-microsoft
approved these changes
May 31, 2024
SergeyMenshykh
approved these changes
May 31, 2024
dmytrostruk
reviewed
Jun 4, 2024
dotnet/src/SemanticKernel.Abstractions/Memory/IMemoryRecordService{TKey,TDataModel}.cs
Show resolved
Hide resolved
|
cc: @roji, @ajcvickers |
stephentoub
reviewed
Jun 4, 2024
stephentoub
reviewed
Jun 4, 2024
westey-m
added a commit
that referenced
this pull request
Jun 5, 2024
…face with related classes. (#6364) Adding an ADR for evolving memory connectors. Related work item: #5887 ### Motivation and Context See included ADR for more motivation and context. ### Description See included ADR for more more info. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
westey-m
added a commit
that referenced
this pull request
Jun 13, 2024
…face with related classes. (#6364) Adding an ADR for evolving memory connectors. Related work item: #5887 ### Motivation and Context See included ADR for more motivation and context. ### Description See included ADR for more more info. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
westey-m
added a commit
that referenced
this pull request
Jun 17, 2024
…face with related classes. (#6364) Adding an ADR for evolving memory connectors. Related work item: #5887 ### Motivation and Context See included ADR for more motivation and context. ### Description See included ADR for more more info. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
westey-m
added a commit
that referenced
this pull request
Jun 24, 2024
…face with related classes. (#6364) Adding an ADR for evolving memory connectors. Related work item: #5887 ### Motivation and Context See included ADR for more motivation and context. ### Description See included ADR for more more info. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
westey-m
added a commit
that referenced
this pull request
Jul 5, 2024
…face with related classes. (#6364) Adding an ADR for evolving memory connectors. Related work item: #5887 ### Motivation and Context See included ADR for more motivation and context. ### Description See included ADR for more more info. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
westey-m
added a commit
that referenced
this pull request
Jul 25, 2024
…face with related classes. (#6364) Adding an ADR for evolving memory connectors. Related work item: #5887 ### Motivation and Context See included ADR for more motivation and context. ### Description See included ADR for more more info. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an ADR for evolving memory connectors.
POC implementations of the included interface can be viewed here:
Related work item:
#5887
Motivation and Context
See included ADR for more motivation and context.
Description
See included ADR for more more info.
Contribution Checklist