Skip to content

.Net: Fix ArgumentNullException from TextPlugin.Uppercase/Lowercase on .NET Framework #6324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2024
Merged

.Net: Fix ArgumentNullException from TextPlugin.Uppercase/Lowercase on .NET Framework #6324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions dotnet/src/Plugins/Plugins.Core/TextPlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ public sealed class TextPlugin
/// <param name="cultureInfo"> An object that supplies culture-specific casing rules. </param>
/// <returns> The converted string. </returns>
[KernelFunction, Description("Convert a string to uppercase.")]
public string Uppercase(string input, CultureInfo? cultureInfo = null) => input.ToUpper(cultureInfo);
public string Uppercase(string input, CultureInfo? cultureInfo = null) =>
input.ToUpper(cultureInfo ?? CultureInfo.CurrentCulture);

/// <summary>
/// Convert a string to lowercase.
Expand All @@ -50,7 +51,8 @@ public sealed class TextPlugin
/// <param name="cultureInfo"> An object that supplies culture-specific casing rules. </param>
/// <returns> The converted string. </returns>
[KernelFunction, Description("Convert a string to lowercase.")]
public string Lowercase(string input, CultureInfo? cultureInfo = null) => input.ToLower(cultureInfo);
public string Lowercase(string input, CultureInfo? cultureInfo = null) =>
input.ToLower(cultureInfo ?? CultureInfo.CurrentCulture);

/// <summary>
/// Get the length of a string. Returns 0 if null or empty
Expand Down
Loading