.Net: fixed extension data in Model diagnostics #6275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
alliscode
reviewed
May 15, 2024
alliscode
approved these changes
May 15, 2024
stephentoub
reviewed
May 15, 2024
stephentoub
reviewed
May 15, 2024
stephentoub
reviewed
May 15, 2024
dotnet/src/Connectors/Connectors.HuggingFace/Core/HuggingFaceMessageApiClient.cs
Show resolved
Hide resolved
stephentoub
reviewed
May 15, 2024
stephentoub
reviewed
May 15, 2024
dotnet/src/InternalUtilities/src/Diagnostics/ModelDiagnostics.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
May 15, 2024
TaoChenOSU
changed the title
Added the line back with a comment and the link to the issue. |
markwallace-microsoft
approved these changes
May 16, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Previously when an AI client starts a model diagnostics activity, it passes in an execution setting that is not parsed to a setting that is specific to the client. This creates an issue where the some of the settings cannot be read by the diagnostics module. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Pass in the parsed setting to the diagnostics module. The diagnostics module will the serialize the object and deserialize it to `PromptExecutionSettings` to get the extension data.  ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Previously when an AI client starts a model diagnostics activity, it passes in an execution setting that is not parsed to a setting that is specific to the client. This creates an issue where the some of the settings cannot be read by the diagnostics module.
Description
Pass in the parsed setting to the diagnostics module. The diagnostics module will the serialize the object and deserialize it to
PromptExecutionSettingsto get the extension data.Contribution Checklist