.Net: Create a classifiable Kernel Function logger #6011
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
dotnet/src/SemanticKernel.Abstractions/Functions/KernelFunction.cs
Outdated
Show resolved
Hide resolved
…n.cs Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
stephentoub
reviewed
Apr 30, 2024
| @@ -156,7 +156,7 @@ internal KernelFunction(string name, string? pluginName, string description, IRe | |||
| Verify.NotNull(kernel); | |||
|
|
|||
| using var activity = s_activitySource.StartActivity(this.Name); | |||
| ILogger logger = kernel.LoggerFactory.CreateLogger(this.Name) ?? NullLogger.Instance; | |||
| ILogger logger = kernel.LoggerFactory.CreateLogger($"{this.GetType()}.{this.Name}") ?? NullLogger.Instance; | |||
There was a problem hiding this comment.
- This means that the implementation detail of the internal derived type's name will end up showing up in logging. That name could easily change. Is this desirable?
- We don't need to allocate a new string on each invocation. It can be cached once and then used on each access. That also avoids the duplication between InvokeAsync and InvokeStreamingAsync.
There was a problem hiding this comment.
- This means that the implementation detail of the internal derived type's name will end up showing up in logging. That name could easily change. Is this desirable?
I think we want to avoid creating logger with name based on function name, because in this case the number of different loggers created will be equal to number of different functions users execute.
Having Microsoft.SemanticKernel.KernelFunction logger name and specific logs like this._logger.LogInformation("Start function execution: {PluginName}-{FunctionName}", this.PluginName, this.Name"); should be enough, and it will be possible to filter logs by FunctionName property in monitoring tool.
|
Replacing with #8107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5989