Skip to content

.Net Agents - Fix AIContext instruction formatting for ChatCompletionAgent streaming invocation #12444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2025

Conversation

crickman
Copy link
Contributor

Motivation and Context

Additional instruction ``Microsoft.SemanticKernel.AIContextbeing added for streaming invocation ofChatCompletionAgent`

Description

  • Centralize all formatting of additional instructions
  • Remove typo that results in Microsoft.SemanticKernel.AIContext additional instruction for streaming ChatCompletionAgent
  • Clarify type usage

Contribution Checklist

@crickman crickman requested review from alliscode and westey-m June 10, 2025 22:14
@crickman crickman self-assigned this Jun 10, 2025
@crickman crickman requested a review from a team as a code owner June 10, 2025 22:14
@crickman crickman added bug Something isn't working .NET Issue or Pull requests regarding .NET code agents labels Jun 10, 2025
@github-actions github-actions bot changed the title .NET Agents - Fix AIContext instruction formatting for ChatCompletionAgent streaming invocation .Net Agents - Fix AIContext instruction formatting for ChatCompletionAgent streaming invocation Jun 10, 2025
@crickman crickman enabled auto-merge June 11, 2025 15:33
@crickman crickman added this pull request to the merge queue Jun 11, 2025
Merged via the queue into main with commit eda707f Jun 11, 2025
19 checks passed
@crickman crickman deleted the fix-agent-additionalinstructions branch June 11, 2025 15:50
@github-project-automation github-project-automation bot moved this to Sprint: Done in Semantic Kernel Jun 11, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jun 19, 2025
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Follow-up to #12444

Fixes: #12472

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

Add support for incorporating `AIContext` when invoking
`OpenAIResponseAgent`
Enabled conformance tests

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄

---------

Co-authored-by: westey <164392973+westey-m@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents bug Something isn't working .NET Issue or Pull requests regarding .NET code
Projects
Status: Sprint: Done
Development

Successfully merging this pull request may close these issues.

4 participants