Skip to content

Python: Remove model info check in Bedrock connectors #12395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025

Conversation

TaoChenOSU
Copy link
Contributor

@TaoChenOSU TaoChenOSU commented Jun 5, 2025

Motivation and Context

Closing #10941

Description

To support more ways (via model_id, inference_profile, or model arn) to send requests to Bedrock models, we have removed the checks on whether a model supports certain features, i.e. streaming and embedding generation. This is because to check for if a model support certain features, we need the model id, but given the flexibility in specifying the target model, it's no longer possible to retrieve the model information realiably.

Contribution Checklist

@TaoChenOSU TaoChenOSU self-assigned this Jun 5, 2025
@TaoChenOSU TaoChenOSU added the python Pull requests for the Python Semantic Kernel label Jun 5, 2025
@TaoChenOSU TaoChenOSU requested a review from a team as a code owner June 5, 2025 23:11
@TaoChenOSU TaoChenOSU added the ai connector Anything related to AI connectors label Jun 5, 2025
@github-actions github-actions bot changed the title Remove model info check in Bedrock connectors Python: Remove model info check in Bedrock connectors Jun 5, 2025
@markwallace-microsoft
Copy link
Member

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
connectors/ai/bedrock/services
   bedrock_base.py100100% 
   bedrock_chat_completion.py1321489%113, 130, 155, 159–162, 220, 238–239, 246–247, 255, 314
   bedrock_text_completion.py53296%94, 112
   bedrock_text_embedding.py39197%86
TOTAL27090461982% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3620 22 💤 0 ❌ 0 🔥 1m 53s ⏱️

@moonbox3 moonbox3 added this pull request to the merge queue Jun 9, 2025
Merged via the queue into main with commit a7eab4a Jun 9, 2025
28 checks passed
@moonbox3 moonbox3 deleted the taochen/python_support_bedrock_inference_profile branch June 9, 2025 21:24
@github-project-automation github-project-automation bot moved this to Sprint: Done in Semantic Kernel Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai connector Anything related to AI connectors documentation python Pull requests for the Python Semantic Kernel
Projects
Status: Sprint: Done
Development

Successfully merging this pull request may close these issues.

4 participants