Skip to content

Python: Add check for not approved and approved for Agent Sample #12316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 19, 2025

Conversation

nmoeller
Copy link
Contributor

@nmoeller nmoeller commented May 30, 2025

Motivation and Context

I was having a Demo with the Agents, and found that step06_chat_completion_agent_group_chat.py sample always terminated after one iteration.

The Reviewer Agent answered "not approved", which also triggered the Termination Strategy, due to the fact that the word approved is also in not approved.
To only trigger when there is a real approval I added a check if the answer is approved and the answer also don't include not approve

Contribution Checklist

@nmoeller nmoeller requested a review from a team as a code owner May 30, 2025 06:53
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label May 30, 2025
@github-actions github-actions bot changed the title Add check for not approved and approved Python: Add check for not approved and approved May 30, 2025
@nmoeller nmoeller changed the title Python: Add check for not approved and approved Python: Add check for not approved and approved for Agent Sample May 30, 2025
@nmoeller nmoeller requested a review from crickman June 10, 2025 07:50
@moonbox3 moonbox3 dismissed crickman’s stale review June 19, 2025 05:25

Code was updated and PR has 2 approvals.

@moonbox3 moonbox3 removed the request for review from crickman June 19, 2025 05:25
@moonbox3 moonbox3 enabled auto-merge June 19, 2025 05:27
@moonbox3 moonbox3 added this pull request to the merge queue Jun 19, 2025
Merged via the queue into microsoft:main with commit 206655a Jun 19, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants