-
Notifications
You must be signed in to change notification settings - Fork 4k
Python: Include Bing Grounding Tool call results in invoke_stream
responses
#12265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Include Bing Grounding Tool call results in invoke_stream
responses
#12265
Conversation
invoke/invoke_stream
responsesinvoke/invoke_stream
responses
Thanks for this, @KanchiShimono. This is using the |
This reverts commit 2631b23.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moonbox3
Thank you for your review.
As you mentioned, I'm using the azure-ai-agents==1.0.0
and azure-ai-projects==1.0.0b11
packages.
By the way, for content that needs special handling, such as Bing search queries, I think it would be ideal to have a dedicated content type like BingGroundingCallContent
.
With FunctionCallContent
, we have to check the function_name
, which can make handling the results a bit more complicated.
Thanks for the comment, @KanchiShimono. I understand that it would be ideal to have a more specific |
@moonbox3 I agree with your point that adding a highly specific type like Here’s what I find tricky about using
|
Hi @KanchiShimono, thanks for the additional comments, they’re very helpful. I agree with your points, and we’ll discuss your suggestion about more scoped content types internally with the SK team. Now that the agent service is GA, we don’t expect any further breaking changes (for example, However, once tool calls are converted to SK’s Let me know if there’s anything I missed or if you have further suggestions. |
@moonbox3 I don’t have any further comments at this time. |
Thanks @KanchiShimono. I will make a new issue to track adding the updated Bing Tool content to the |
Python Test Coverage Report •
Python Unit Test Overview
|
invoke/invoke_stream
responsesinvoke_stream
responses
Motivation and Context
According to the Terms of Service for Grounding with Bing Search, the tool’s call results must be displayed in their original format.
Currently, in the
AzureAIAgent
invoke/invoke_stream
responses, search results are included in theAnnotationContent
, but the search query itself is not.This PR updates the response of
invoke/invoke_stream
to include the Bing Grounding Tool’s call results, so that the Bing search query can also be displayed.Description
invoke/invoke_stream
responses to include the Bing Grounding Tool call resultsContribution Checklist