Skip to content

Python: Relax Agent Invocation Methods to Allow Positional or Keyword Arguments for messages #12248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions python/semantic_kernel/agents/agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,8 @@ async def _as_kernel_function(
@abstractmethod
def get_response(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
**kwargs,
) -> Awaitable[AgentResponseItem[ChatMessageContent]]:
Expand Down Expand Up @@ -336,8 +336,8 @@ def get_response(
@abstractmethod
def invoke(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
on_intermediate_message: Callable[[ChatMessageContent], Awaitable[None]] | None = None,
**kwargs,
Expand Down Expand Up @@ -367,8 +367,8 @@ def invoke(
@abstractmethod
def invoke_stream(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
on_intermediate_message: Callable[[ChatMessageContent], Awaitable[None]] | None = None,
**kwargs,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ def __init__(self, conversable_agent: ConversableAgent, **kwargs: Any) -> None:
async def get_response(
self,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
**kwargs: Any,
) -> AgentResponseItem[ChatMessageContent]:
Expand Down Expand Up @@ -170,8 +171,8 @@ async def get_response(
@override
async def invoke(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
recipient: "AutoGenConversableAgent | None" = None,
clear_history: bool = True,
Expand Down Expand Up @@ -254,8 +255,8 @@ async def invoke(
@override
def invoke_stream(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
kernel: "Kernel | None" = None,
arguments: KernelArguments | None = None,
Expand Down
6 changes: 3 additions & 3 deletions python/semantic_kernel/agents/azure_ai/azure_ai_agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -606,8 +606,8 @@ def replacer(match: re.Match[str]) -> str:
@override
async def get_response(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
arguments: KernelArguments | None = None,
kernel: Kernel | None = None,
Expand Down Expand Up @@ -710,8 +710,8 @@ async def get_response(
@override
async def invoke(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
on_intermediate_message: Callable[[ChatMessageContent], Awaitable[None]] | None = None,
arguments: KernelArguments | None = None,
Expand Down Expand Up @@ -815,8 +815,8 @@ async def invoke(
@override
async def invoke_stream(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
on_intermediate_message: Callable[[ChatMessageContent], Awaitable[None]] | None = None,
arguments: KernelArguments | None = None,
Expand Down
6 changes: 3 additions & 3 deletions python/semantic_kernel/agents/bedrock/bedrock_agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,8 @@ async def create_and_prepare_agent(
@override
async def get_response(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
agent_alias: str | None = None,
arguments: KernelArguments | None = None,
Expand Down Expand Up @@ -358,8 +358,8 @@ async def get_response(
@override
async def invoke(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
on_new_message: Callable[[ChatMessageContent], Awaitable[None]] | None = None,
agent_alias: str | None = None,
Expand Down Expand Up @@ -462,8 +462,8 @@ async def invoke(
@override
async def invoke_stream(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
on_new_message: Callable[[ChatMessageContent], Awaitable[None]] | None = None,
agent_alias: str | None = None,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,8 @@ async def _from_dict(
@override
async def get_response(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
arguments: KernelArguments | None = None,
kernel: "Kernel | None" = None,
Expand Down Expand Up @@ -317,8 +317,8 @@ async def get_response(
@override
async def invoke(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
on_intermediate_message: Callable[[ChatMessageContent], Awaitable[None]] | None = None,
arguments: KernelArguments | None = None,
Expand Down Expand Up @@ -365,8 +365,8 @@ async def invoke(
@override
async def invoke_stream(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
on_intermediate_message: Callable[[ChatMessageContent], Awaitable[None]] | None = None,
arguments: KernelArguments | None = None,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -420,8 +420,8 @@ def create_client(
@override
async def get_response(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
arguments: KernelArguments | None = None,
kernel: "Kernel | None" = None,
Expand Down Expand Up @@ -467,8 +467,8 @@ async def get_response(
@override
async def invoke(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
on_intermediate_message: Callable[[ChatMessageContent], Awaitable[None]] | None = None,
arguments: KernelArguments | None = None,
Expand Down Expand Up @@ -512,8 +512,8 @@ async def invoke(
@override
def invoke_stream(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
on_intermediate_message: Callable[[ChatMessageContent], Awaitable[None]] | None = None,
arguments: KernelArguments | None = None,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,8 @@ async def create_channel(self, thread_id: str | None = None) -> AgentChannel:
@override
async def get_response(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
arguments: KernelArguments | None = None,
additional_instructions: str | None = None,
Expand Down Expand Up @@ -549,8 +549,8 @@ async def get_response(
@override
async def invoke(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
on_intermediate_message: Callable[[ChatMessageContent], Awaitable[None]] | None = None,
arguments: KernelArguments | None = None,
Expand Down Expand Up @@ -657,8 +657,8 @@ async def invoke(
@override
async def invoke_stream(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
on_intermediate_message: Callable[[ChatMessageContent], Awaitable[None]] | None = None,
additional_instructions: str | None = None,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -548,8 +548,8 @@ def configure_response_format(
@override
async def get_response(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
arguments: KernelArguments | None = None,
kernel: "Kernel | None" = None,
Expand Down Expand Up @@ -668,8 +668,8 @@ async def get_response(
@override
async def invoke(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
on_intermediate_message: Callable[[ChatMessageContent], Awaitable[None]] | None = None,
arguments: KernelArguments | None = None,
Expand Down Expand Up @@ -786,8 +786,8 @@ async def invoke(
@override
async def invoke_stream(
self,
*,
messages: str | ChatMessageContent | list[str | ChatMessageContent] | None = None,
*,
thread: AgentThread | None = None,
on_intermediate_message: Callable[[ChatMessageContent], Awaitable[None]] | None = None,
arguments: KernelArguments | None = None,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ async def test_autogen_conversable_agent_get_response(mock_conversable_agent):
agent = AutoGenConversableAgent(mock_conversable_agent)
thread: AutoGenConversableAgentThread = None

response = await agent.get_response("Hello", thread)
response = await agent.get_response("Hello", thread=thread)
assert response.message.role == AuthorRole.ASSISTANT
assert response.message.content == "Mocked assistant response"
assert response.thread is not None
Expand Down
Loading